From owner-freebsd-arch@FreeBSD.ORG Tue Apr 23 17:28:47 2013 Return-Path: Delivered-To: arch@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 5CAA1F76; Tue, 23 Apr 2013 17:28:47 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pa0-f53.google.com (mail-pa0-f53.google.com [209.85.220.53]) by mx1.freebsd.org (Postfix) with ESMTP id 28CDD1285; Tue, 23 Apr 2013 17:28:47 +0000 (UTC) Received: by mail-pa0-f53.google.com with SMTP id bh4so631469pad.12 for ; Tue, 23 Apr 2013 10:28:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:subject:mime-version:content-type:from:in-reply-to:date :cc:content-transfer-encoding:message-id:references:to:x-mailer; bh=MVDWPTHNYYS4fVs5dRvhlABR0qks+Z5qkwT5ge6b4KI=; b=bGFzWIA/khdEiJ1u6TDkTU7sgP8X04EntXp/KSh8LOy6+IxcXKdlvvJlQ0Qkv/oUvw EYN7P39TTVKhSunq8SrbJTtrZ+I6SPFxEMY5ZotwqWitDMTKqjIA86DF7ViH6uQTIJ1r cFOjNLKom/0OusBaM5CWXOanPCsABcE4GwL7TFEFwQ2GPcPjNCqiZoMwQtMoqeU92oy7 AlYU+YaALPHBlvx68cMV8o6r9d9cVRkpZehB8ykzRl8sdwKPaZ/nANWE32Bz9PfrSX1p bjk4GgRegt4ioLNHkaBofuF8MSSsQG/pIJag7q+RZjhCYiIlGPDIDmRv0pTANDnqYiZV xIOA== X-Received: by 10.67.1.69 with SMTP id be5mr14689822pad.154.1366738126791; Tue, 23 Apr 2013 10:28:46 -0700 (PDT) Received: from fuji-wireless.local (c-98-203-241-95.hsd1.wa.comcast.net. [98.203.241.95]) by mx.google.com with ESMTPS id qh4sm32636986pac.8.2013.04.23.10.28.45 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 23 Apr 2013 10:28:46 -0700 (PDT) Subject: Re: [RFC] [Optionally] build tests with buildworld Mime-Version: 1.0 (Apple Message framework v1283) Content-Type: text/plain; charset=us-ascii From: Garrett Cooper In-Reply-To: <20130423165958.GA91607@lor.one-eyed-alien.net> Date: Tue, 23 Apr 2013 10:28:44 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: <1D2E12CF-08F2-4151-AB33-84C4270CFBC6@gmail.com> References: <20130423165958.GA91607@lor.one-eyed-alien.net> To: Brooks Davis X-Mailer: Apple Mail (2.1283) Cc: arch@freebsd.org, "Simon J. Gerraty" , benno@FreeBSD.org, toolchain@freebsd.org X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Apr 2013 17:28:47 -0000 Hi Brooks! On Apr 23, 2013, at 9:59 AM, Brooks Davis wrote: > On Fri, Apr 19, 2013 at 11:17:50PM -0700, Garrett Cooper wrote: >> Hi arch@ and toolchain@, >> One of the items that I'm proposing be added to Makefile.inc1 in >> order to make building and installing tests on CURRENT (ATF and >> otherwise) is a build knob called TESTS_WITH_WORLD (the name can be >> modified), which allows me to build and install various tests on my >> git branch like the example ATF tests I produced, pjdfstest, some of >> the prove tests from tools/regression, etc (there are other >> outstanding changes, but this was the key one that I need feedback on >> just to be safe). >=20 > I don't understand way you don't use WITH_TESTS processed > through bsd.own.mk. You'd presumably have to add it to the list of > supported NO_* options for the bootstrap case, but that's trivial. = Then > you use could use normal MK_* variables. That would also let you use > WITH(OUT)_TESTS in individual directories and they would always work. >=20 > At a glance using WITHOUT_TESTS and NO_TEST internally would simplify > some of the special cases in your patch. This is something that I considered, but I wasn't sure that it was the = best route to go about things because I thought we were doing away/had = done away with most of the NO_* knobs (and unfortunately one cannot mix = and match WITH_* and WITHOUT_* because they're considered contradictory = according to bsd.own.mk -- something that Simon has debated against = having in the past). I'm all for doing that though because that would simplify things greatly = from an end-user perspective. > On a side note, I like the HMAKE change independent of the rest of the > patch. Cool! I'll polish up the patch with that piece and send it over to = benno@ :). Thanks! -Garrett=