From owner-svn-src-head@FreeBSD.ORG Wed Oct 1 20:07:53 2014 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 75AD5231 for ; Wed, 1 Oct 2014 20:07:53 +0000 (UTC) Received: from nm44-vm6.bullet.mail.bf1.yahoo.com (nm44-vm6.bullet.mail.bf1.yahoo.com [216.109.115.30]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 15AF4EB6 for ; Wed, 1 Oct 2014 20:07:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1412193736; bh=cf7E+hfqbP2psrIjyc1if1EcF7mbC8faDFhRjIBgVqQ=; h=Received:Received:Received:X-Yahoo-Newman-Id:X-Yahoo-Newman-Property:X-YMail-OSG:X-Yahoo-SMTP:Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject:References:In-Reply-To:Content-Type:Content-Transfer-Encoding:From:Subject; b=ixnDcaYRIjQeFAUkcdcBlGDJOKVQMNKx2O2KyhHqJl15iYsgf20zxfnJruUG9Q30fM0QefKoXgSfiOXVTI3MhDr8VszH6ClTliXcIerlYlSjVcPe6OKI1fCHpa2XfM0NjreXJMXYtrQStiZyx9+V6e5/rIr0hxXcL2hM8W8NW5CBhsX9BpwfCTreSqu/aECBwbJMBETe1zdp1UCCMF/3TJInf+0WfH5zFWw/dZRw9HvKtw8Ne+q6TPCeBOGyTf+4vevaa7WhcOf94GdJv4J8IphtzU8y5bNikVhp8kSXl6/dwraXqg8IpdHEh05iShg2VgDmR9w70MuVzNXKcCX+Vw== DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s2048; d=yahoo.com; b=oi6St+lN/KMiR2PxUZppIeG6UDe81a+ffvQ5L5a2ytJkv0XhGBh5NJn7+OEGgsXQP2Uruznw88YKI/2dvwrZx7rI1UKfif8q9cefXJ+k4aU+rV2ofgkW60MtYE5LefxT0/aqbTXzHZSfAurZZjeKr88bxdGnKG38xEyHN2BL5zPqiQfXvXWQW5WJ5Ag0OrPbVspwng67JRpHlndHWCAwGuzl3CVGnJrmHkHCwWJNeTa1F7AtSKd/FoPU+29fDWXeBBngJlHDZ9FFkqSbqOOu48gcH+mT955uInLWlwdkmvYjyHC4yTmBE7WqCaILvLW7hFPlXFs/ZZCQWFgg4x/HOA==; Received: from [98.139.214.32] by nm44.bullet.mail.bf1.yahoo.com with NNFMP; 01 Oct 2014 20:02:16 -0000 Received: from [98.139.211.161] by tm15.bullet.mail.bf1.yahoo.com with NNFMP; 01 Oct 2014 20:02:16 -0000 Received: from [127.0.0.1] by smtp218.mail.bf1.yahoo.com with NNFMP; 01 Oct 2014 20:02:16 -0000 X-Yahoo-Newman-Id: 847888.33515.bm@smtp218.mail.bf1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: .un7UrMVM1limzaoPCQoWOCKCNiyKb6o2MiuEaGHO6HFdli ysQLMC9f_gLZgvwhxuzJVyt.rJmF7jtzeqI89CtS4e7ivup83GG4nknwilM1 NnQneUY9Fydh43..rX9n9UDmxwizxIABsvvI1OgCWGUJ1op5IFoeufd8x36Q OmRkgxn_HDmV9A.V5nrUcT2HN0GJ.XCb4CwluocT1M_5vBE3y00iG3WPa9Cx Esy4ZKrIfHWFhhkyBILQjcKIqJl.uLidLAv_Vnuc_7LUTPDq_cOu3L6Xw2V0 0RgBXOs1qpf1COqn0_b17mzwIjJL6ISI0Fnf6R2LAqaAyl2fNfmyEg8UCh4s ft.X5m53PcSXKUK4nbF_eQX5ZGJxWmyPXzjJ8KLZu9qmgB.1dimCt97cu_Go mZfQgM_SqkskJoZhSzS4D8yTwaEJ8P8Ig_dtL59y4ArTXvC1xDJlb4Iy2lDP P4aRDaCzUN2mCLYEV84UpZp0LTV6VFHC3p4TKJ2ItSa73hmxebigvaXyix4V zJhS4QDzZucYaRNR24mN_hvs782W9w9QuMFOnaWhBg.c8c9Lnc.hJh50s4bk SrqrarnIRJqtam33xt3dNldSlSC4KslR6Ob7n X-Yahoo-SMTP: xcjD0guswBAZaPPIbxpWwLcp9Unf Message-ID: <542C5DCC.8060406@freebsd.org> Date: Wed, 01 Oct 2014 15:02:20 -0500 From: Pedro Giffuni User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: "Andrey A. Chernov" Subject: New bug introduced in strptime (was Re: svn commit: r272273 - head/lib/libc/stdtime) References: <201409282120.s8SLKLJs070469@svn.freebsd.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, Antoine Brodin , David Carlier X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Oct 2014 20:07:53 -0000 Hello; I can reproduce this. On FreeBSD 9.1 (no patch): pfg@minotaur:~$ uname -a FreeBSD minotaur.apache.org 9.1-RELEASE-p6 FreeBSD 9.1-RELEASE-p6 #0 r254631: Thu Aug 22 13:59:50 UTC 2013 root@loki.apache.org:/usr/obj/usr/src/sys/ASF amd64 pfg@minotaur:~$ date -j -f '%a, %e %b %Y %T %z' "Sat, 01 Aug 2009 18:07:18 +0200" +%B August On my box with the patch applied: $ date -j -f '%a, %e %b %Y %T %z' "Sat, 01 Aug 2009 18:07:18 +0200" +%B Failed conversion of ``Sat, 01 Aug 2009 18:07:18 +0200'' using format ``%a, %e %b %Y %T %z'' date: illegal time format usage: date [-jnRu] [-d dst] [-r seconds] [-t west] [-v[+|-]val[ymwdHMS]] ... [-f fmt date | [[[[[cc]yy]mm]dd]HH]MM[.ss]] [+format] Regards, Pedro. On 10/01/14 11:46, Antoine Brodin wrote: > On Sun, Sep 28, 2014 at 11:20 PM, Pedro F. Giffuni wrote: >> Author: pfg >> Date: Sun Sep 28 21:20:20 2014 >> New Revision: 272273 >> URL: http://svnweb.freebsd.org/changeset/base/272273 >> >> Log: >> Add strptime(3) support for %U and %W (take 2) >> >> Add support for the missing POSIX-2001 %U and %W features: the >> existing FreeBSD strptime code recognizes both directives and >> validates that the week number lies in the permitted range, >> but then simply discards the value. >> >> Initial support for the feature was written by Paul Green. >> David Carlier added the initial handling of tm_wday/tm_yday. >> Major credit goes to Andrey Chernov for detecting much of the >> brokenness, and rewriting/cleaning most of the code, making it >> much more robust. >> >> Tested independently with the strptime test from the GNU C >> library. >> >> PR: 137307 >> MFC after: 1 month >> Relnotes: yes > Hi, > > It seems this change breaks some ports, so please no MFC until this is fixed: > > http://gohan2.ysv.freebsd.org/data/head-amd64-default-baseline/p369565_s272290/logs/errors/latrine-1.0.0_1.log > http://gohan2.ysv.freebsd.org/data/head-amd64-default-baseline/p369565_s272290/logs/errors/mongrel2-1.7.5_2.log > http://gohan2.ysv.freebsd.org/data/head-amd64-default-baseline/p369565_s272290/logs/errors/deforaos-mailer-0.1.6_1.log > > Cheers, > > Antoine (portmgr hat on) > >