From owner-svn-src-head@FreeBSD.ORG Wed May 2 20:56:07 2012 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id E0181106566C; Wed, 2 May 2012 20:56:07 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net [IPv6:2001:470:1f10:75::2]) by mx1.freebsd.org (Postfix) with ESMTP id B4AE48FC15; Wed, 2 May 2012 20:56:07 +0000 (UTC) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 24717B96D; Wed, 2 May 2012 16:56:07 -0400 (EDT) From: John Baldwin To: Doug Barton Date: Wed, 2 May 2012 16:34:21 -0400 User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110714-p13; KDE/4.5.5; amd64; ; ) References: <201205021425.q42EPdqw088857@svn.freebsd.org> <4FA18A1B.30203@FreeBSD.org> In-Reply-To: <4FA18A1B.30203@FreeBSD.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201205021634.21898.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Wed, 02 May 2012 16:56:07 -0400 (EDT) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r234927 - in head: etc/rc.d sys/kern X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 May 2012 20:56:08 -0000 On Wednesday, May 02, 2012 3:25:15 pm Doug Barton wrote: > On 5/2/2012 7:25 AM, John Baldwin wrote: > > - Simplify accounting log rotation a bit. There is no need to re-run > > accton(8) after renaming the new log file to it's real name. > > Have you thoroughly tested this change? I remember adding that on > purpose, but I couldn't tell you for sure at this point exactly why. The reporter tested it. However, the kernel has no notion of the pathname once it has opened the file. It just holds a reference to the vnode directly, and the rename of the file will not invalidate that reference. -- John Baldwin