From owner-svn-src-head@FreeBSD.ORG Wed Nov 27 07:37:51 2013 Return-Path: Delivered-To: svn-src-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 9F419C30; Wed, 27 Nov 2013 07:37:51 +0000 (UTC) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 5CD072CDE; Wed, 27 Nov 2013 07:37:49 +0000 (UTC) Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id JAA28991; Wed, 27 Nov 2013 09:37:46 +0200 (EET) (envelope-from avg@FreeBSD.org) Received: from localhost ([127.0.0.1]) by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1VlZgv-0005B3-TD; Wed, 27 Nov 2013 09:37:45 +0200 Message-ID: <5295A111.50407@FreeBSD.org> Date: Wed, 27 Nov 2013 09:36:49 +0200 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 MIME-Version: 1.0 To: Peter Wemm , Glen Barber Subject: Re: svn commit: r258672 - in head: . share/mk References: <201311270454.rAR4sOqI004103@svn.freebsd.org> <20131127050358.GG1710@glenbarber.us> <52959276.7070803@wemm.org> In-Reply-To: <52959276.7070803@wemm.org> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Nov 2013 07:37:51 -0000 on 27/11/2013 08:34 Peter Wemm said the following: > On 11/26/13, 9:03 PM, Glen Barber wrote: >> On Wed, Nov 27, 2013 at 04:54:24AM +0000, Peter Wemm wrote: >>> Author: peter >>> Date: Wed Nov 27 04:54:23 2013 >>> New Revision: 258672 >>> URL: http://svnweb.freebsd.org/changeset/base/258672 >>> >>> Log: >>> At great personal risk, change the default for LIB32 from yes to no. As >>> mentioned in UPDATING, you can even do it as an as-needed operation after >>> doing a buildworld/installworld. You can set WITH_LIB32=yes in make.conf >>> or src.conf. >>> >> >> Thank you. Long overdue, IMHO. >> >> Glen >> > > A slightly longer explanation of what I was thinking: > > - There's a new round of 'make -j' problems lurking in there. We are > missing chunks of the ordering glue that cause libraries to be built in the > right order when they depend on each other. > - It's a waste of cpu time for the usual case, particularly for the 11.x > cycle for the next 1-2 years. Do this change and this point make sense if everyone building virtualbox (and perhaps running it) has to install lib32 anyway? pre-everything:: .if ${ARCH} == "amd64" .if !exists(/usr/lib32/libc.so) @${ECHO} 'Requires 32-bit libraries installed under /usr/lib32.' @${ECHO} 'Do: cd /usr/src; make build32 install32; /etc/rc.d/ldconfig restart' @${FALSE} .endif .endif Just in case, I have no clue why this is required. > - We don't build them properly - we invent cpu flags etc. > > The usual use case for 32 bit binaries seems to be: > - running a 32 bit chroot or jail - this is unaffected. > - running old binaries, usually from 4.x or 6.x when the 64 bit port was > really green - WITH_LIB32 doesn't actually help much with this because most > of the libraries are missing. > > It seems more likely we can do a better job with packages. With some > massaging, we should be able to use the compat-6.x/i386 libraries as-is, and > solve the "old 4.x/6.x binary" issue in one go. > > However, ld-elf32.so.1 does require special handling. I have something in > mind that might make this moot though. > > I suspect I've made the powerpc folks angry though... > -- Andriy Gapon