From owner-svn-src-all@FreeBSD.ORG Thu Oct 7 09:58:52 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 77874106566C; Thu, 7 Oct 2010 09:58:52 +0000 (UTC) (envelope-from netchild@freebsd.org) Received: from mail.ebusiness-leidinger.de (mail.ebusiness-leidinger.de [217.11.53.44]) by mx1.freebsd.org (Postfix) with ESMTP id 1EA978FC13; Thu, 7 Oct 2010 09:58:51 +0000 (UTC) Received: from outgoing.leidinger.net (p57B3B2F4.dip.t-dialin.net [87.179.178.244]) by mail.ebusiness-leidinger.de (Postfix) with ESMTPSA id B5DA184400C; Thu, 7 Oct 2010 11:40:41 +0200 (CEST) Received: from webmail.leidinger.net (unknown [IPv6:fd73:10c7:2053:1::2:102]) by outgoing.leidinger.net (Postfix) with ESMTP id B1D6818F7; Thu, 7 Oct 2010 11:40:34 +0200 (CEST) Received: (from www@localhost) by webmail.leidinger.net (8.14.4/8.13.8/Submit) id o979eVMA095799; Thu, 7 Oct 2010 11:40:31 +0200 (CEST) (envelope-from netchild@FreeBSD.org) Received: from pslux.ec.europa.eu (pslux.ec.europa.eu [158.169.9.14]) by webmail.leidinger.net (Horde Framework) with HTTP; Thu, 07 Oct 2010 11:40:31 +0200 Message-ID: <20101007114031.80652w26vlw6cwis@webmail.leidinger.net> Date: Thu, 07 Oct 2010 11:40:31 +0200 From: Alexander Leidinger To: Doug Barton References: <201010060749.o967nSbZ086734@svn.freebsd.org> <4CACBCA4.3080006@FreeBSD.org> In-Reply-To: <4CACBCA4.3080006@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; DelSp="Yes"; format="flowed" Content-Disposition: inline Content-Transfer-Encoding: 7bit User-Agent: Dynamic Internet Messaging Program (DIMP) H3 (1.1.4) X-EBL-MailScanner-Information: Please contact the ISP for more information X-EBL-MailScanner-ID: B5DA184400C.A89BD X-EBL-MailScanner: Found to be clean X-EBL-MailScanner-SpamCheck: not spam, spamhaus-ZEN, SpamAssassin (not cached, score=1.351, required 6, autolearn=disabled, RDNS_NONE 1.27, TW_SV 0.08) X-EBL-MailScanner-SpamScore: s X-EBL-MailScanner-From: netchild@freebsd.org X-EBL-MailScanner-Watermark: 1287049244.02871@mEDiwlb2D8COilY8mgFeYA X-EBL-Spam-Status: No Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, Paul B Mahol Subject: Re: svn commit: r213472 - head/tools/build/mk X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Oct 2010 09:58:52 -0000 Quoting Doug Barton (from Wed, 06 Oct 2010 11:15:00 -0700): > On 10/6/2010 12:49 AM, Alexander Leidinger wrote: >> Author: netchild >> Date: Wed Oct 6 07:49:28 2010 >> New Revision: 213472 >> URL: http://svn.freebsd.org/changeset/base/213472 >> >> Log: >> Add some missing files to optionally delete. >> >> Submitted by: Paul B Mahol >> >> Modified: >> head/tools/build/mk/OptionalObsoleteFiles.inc >> >> Modified: head/tools/build/mk/OptionalObsoleteFiles.inc >> ============================================================================== >> --- head/tools/build/mk/OptionalObsoleteFiles.inc Wed Oct 6 >> 07:34:41 2010 (r213471) >> +++ head/tools/build/mk/OptionalObsoleteFiles.inc Wed Oct 6 >> 07:49:28 2010 (r213472) >> @@ -141,6 +141,7 @@ OLD_FILES+=usr/share/man/man8/authpf.8.g >> .endif >> >> .if ${MK_BIND} == no >> +OLD_FILES+=etc/periodic/daily/470.status-named > > > Traditionally we haven't deleted these. In the case of named-related > files I would prefer that we did not because: > > 1. That check is off by default > 2. If the user is not running named it won't do any harm > 3. The default for installing named from the ports is to continue to > use the infrastructure in the base (such as this script, and > /etc/rc.d/named). > > I'm not sure what the right answer for all the periodic scripts is, > but for this one I would like it not to be included in the obsolete > files. Please confirm that this file is installed during installworld when MK_BIND is equal to "no" (as I read it, it is not installed). I agree that it makes sense to keep this file (and at least one which is covered by the sendmail knob), but the design of "delete-old" is to remove everything which is not installed anymore (= the file has to be deleted if MK_BIND is equal to "no"). If the script is installed during installworld (= I haven't read the Makefile correctly), the script is not allowed to be deleted (and the above piece of the patch is wrong = pointyhat to me). If the script is not installed during installworld, the above patch is 100% correct and the delete-old is working as designed. If you do not want to have it deleted by delete-old, do not exclude it during installworld (you have my vote for this) and remove its entry from OptionalObsoleteFiles.inc. Bye, Alexander. -- http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID = B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID = 72077137 Postmen never die, they just lose their zip.