From owner-cvs-src@FreeBSD.ORG Fri Apr 16 05:31:32 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7AA1E16A4CF for ; Fri, 16 Apr 2004 05:31:32 -0700 (PDT) Received: from hanoi.cronyx.ru (hanoi.cronyx.ru [144.206.181.53]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8A89A43D2F for ; Fri, 16 Apr 2004 05:31:30 -0700 (PDT) (envelope-from rik@cronyx.ru) Received: (from root@localhost) by hanoi.cronyx.ru id i3GCT4Ur036765 for cvs-src@FreeBSD.ORG.checked; (8.12.8/vak/2.1) Fri, 16 Apr 2004 16:29:04 +0400 (MSD) (envelope-from rik@cronyx.ru) Received: from cronyx.ru (hi.cronyx.ru [144.206.181.94]) by hanoi.cronyx.ru with ESMTP id i3GCPgv4036474; (8.12.8/vak/2.1) Fri, 16 Apr 2004 16:25:42 +0400 (MSD) (envelope-from rik@cronyx.ru) Message-ID: <407FD0BB.1080307@cronyx.ru> Date: Fri, 16 Apr 2004 16:25:31 +0400 From: Roman Kurakin User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.6b) Gecko/20031208 X-Accept-Language: en-us, en MIME-Version: 1.0 To: =?UTF-8?B?U8O4cmVuIFNjaG1pZHQ=?= References: <20040413094519.7230616A4DB@hub.freebsd.org> <20040415162313.S92883@root.org> <407F9CB7.3020407@DeepCore.dk> <407FC333.6000901@cronyx.ru> <407FC67A.7090306@DeepCore.dk> In-Reply-To: <407FC67A.7090306@DeepCore.dk> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit cc: cvs-src@FreeBSD.ORG cc: src-committers@FreeBSD.ORG cc: cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/dev/ata ata-all.c ata-all.h ata-card.c ata-lowlevel.c ata-pci.c ata-pci.h ata-queue.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Apr 2004 12:31:32 -0000 Søren Schmidt wrote: [...] > Right, it may break ATA on old devices though, but I guess none of > these drives are in use any more. > The real problem here is that I cannot just use the latest ATA specs > (it would make my life *alot* simpler though :) ), I need to make > things work that are compatible to at least back to ATA rev3 so just > relying on things be obsoleted in the latest spec revision doesn't cut > it.. Thats why I was trying to find out other ways to solve my problem rather than insist to remove this check :-) >> Code I submitted was to make ata driver more verbose about CHS mode. >> They still are not there and should be revised to make them possible to >> apply to current code. > > I'll think about it, but since CHS mode is almost no longer used anyways > and the info can pretty easily be calculated from the LBA's printed.. Yes, but hex format or printing CHS and LBA request would save some amount of time. >> By the way, may be it would be a nice idea to warn users that they have >> ATA_FLAG_54_58 bit off, and device will work in LBA mode not >> in CHS as was before? > > Users wont notice at all, from users perspective the disk is just a > bunch of sectors, > the interface method used to talk to the disk is nowhere to be seen... Hm, I noticed interface method :-). My hdd started to work in CHS mode (without any notice to me), but only by its quarter. This sign was imposible to miss. Thats why I ask you about additional verbosity.