From owner-svn-ports-all@FreeBSD.ORG  Tue Apr 14 07:36:56 2015
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 6C2373F3;
 Tue, 14 Apr 2015 07:36:56 +0000 (UTC)
Received: from f10.opsec.eu (f10.opsec.eu [IPv6:2001:14f8:200:4::2])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 28FBA298;
 Tue, 14 Apr 2015 07:36:56 +0000 (UTC)
Received: from pi by f10.opsec.eu with local (Exim 4.85 (FreeBSD))
 (envelope-from <pi@FreeBSD.org>)
 id 1YhvOv-000CxC-H5; Tue, 14 Apr 2015 09:36:53 +0200
Date: Tue, 14 Apr 2015 09:36:53 +0200
From: Kurt Jaeger <pi@FreeBSD.org>
To: Alexey Dokuchaev <danfe@FreeBSD.org>
Cc: Kurt Jaeger <pi@FreeBSD.org>, ports-committers@freebsd.org,
 svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject: Re: svn commit: r383978 - head/multimedia/handbrake
Message-ID: <20150414073653.GH1017@f10.opsec.eu>
References: <201504140613.t3E6D48n077306@svn.freebsd.org>
 <20150414062552.GA1692@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150414062552.GA1692@FreeBSD.org>
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 14 Apr 2015 07:36:56 -0000

Hi!

> >   multimedia/handbrake: fix X11_DESC
> 
> It's very unfortunate that handbrake become gtk3-only; two questions in this
> regard:
> 
>   - does it still support gtk20 gui, and

I did not investigate this. I was not aware that there's a debate/policy
to keep gtk20 alive. Is there one ? Where can I read more about it ?

>   - if yes, shouldn't it be an OPTION?

Given that the port is unmaintained, someone needs to find out. Can
you open a PR ?

> > [...]
> >  OPTIONS_DEFINE=	X11
> > -X11_DESC=	Build GTK+2 based GUI program
> > +X11_DESC=	Build GTK3 based GUI program
> 
> Where did plus sign go?  Please respect official project names.  It is
> still GTK+ per what I read at their website [1].

It's back with the next commit.

-- 
pi@FreeBSD.org         +49 171 3101372                5 years to go !