From owner-freebsd-current@FreeBSD.ORG Wed Mar 28 13:00:42 2007 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 9577316A409 for ; Wed, 28 Mar 2007 13:00:42 +0000 (UTC) (envelope-from andre@freebsd.org) Received: from c00l3r.networx.ch (c00l3r.networx.ch [62.48.2.2]) by mx1.freebsd.org (Postfix) with ESMTP id E932C13C468 for ; Wed, 28 Mar 2007 13:00:41 +0000 (UTC) (envelope-from andre@freebsd.org) Received: (qmail 18065 invoked from network); 28 Mar 2007 12:28:25 -0000 Received: from c00l3r.networx.ch (HELO [127.0.0.1]) ([62.48.2.2]) (envelope-sender ) by c00l3r.networx.ch (qmail-ldap-1.03) with SMTP for ; 28 Mar 2007 12:28:25 -0000 Message-ID: <460A66F9.7000005@freebsd.org> Date: Wed, 28 Mar 2007 15:00:41 +0200 From: Andre Oppermann User-Agent: Thunderbird 1.5.0.10 (Windows/20070221) MIME-Version: 1.0 To: Andrey Chernov , Andre Oppermann , Garrett Cooper , freebsd-current@freebsd.org References: <200703251620.20879.nb_root@videotron.ca> <20070325202749.GA1503@kobe.laptop> <460705AE.5040107@freebsd.org> <20070327045252.GA3256@nagual.pp.ru> <46099675.3040609@u.washington.edu> <20070327052810.GA772@nagual.pp.ru> <20070327054501.GA1026@nagual.pp.ru> <46090BA6.5060206@freebsd.org> <20070328074611.GA19740@nagual.pp.ru> <460A2B97.9040404@freebsd.org> <20070328085104.GA20674@nagual.pp.ru> In-Reply-To: <20070328085104.GA20674@nagual.pp.ru> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Subject: Re: Latest -current complete lockup (tcp changes?) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Mar 2007 13:00:42 -0000 Andrey Chernov wrote: > On Wed, Mar 28, 2007 at 10:47:19AM +0200, Andre Oppermann wrote: >> Andrey Chernov wrote: >>> On Tue, Mar 27, 2007 at 02:18:46PM +0200, Andre Oppermann wrote: >>> >>>> Could you revert sys/netinet/tcp_input.c back to rev. 1.327 while leaving >>>> all others at HEAD and look if the bug can be reproduced? >>> >>> Yes! Reverting to 1.327 really helps, lockup is gone! Thanx! >> You tried with a fully updated system before the backout as well? >> There was a time window where TCP was indeed broken. It panic'ed >> though. > > Yes. My case is not related to SACK options KASSERT - my kernel even not > go so far to get that panic and I get lockup even when disable SACK by > sysctl. The problem is fixed in rev. 1.330 of tcp_input.c. Thanks to Robert for finding the bug. It was a INP_INFO_LOCK leak in the blackhole case that I missed during the tcp_input() split. There was a slight change in semantics. Sorry for the trouble. -- Andre