From owner-svn-src-head@freebsd.org  Sun Oct 30 22:07:47 2016
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id A14EEC2754F;
 Sun, 30 Oct 2016 22:07:47 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from mail.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1])
 (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 80B3C1111;
 Sun, 30 Oct 2016 22:07:47 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from ralph.baldwin.cx (c-73-231-226-104.hsd1.ca.comcast.net
 [73.231.226.104])
 by mail.baldwin.cx (Postfix) with ESMTPSA id AD36710AF92;
 Sun, 30 Oct 2016 18:07:38 -0400 (EDT)
From: John Baldwin <jhb@freebsd.org>
To: Li-Wen Hsu <lwhsu@freebsd.org>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: Re: svn commit: r308107 - in head/sys/modules/bhnd: . bcma bcma_bhndb
 bhndb bhndb_pci cores/bhnd_pci cores/bhnd_pci_hostb cores/bhnd_pcib siba
 siba_bhndb
Date: Sun, 30 Oct 2016 15:05:49 -0700
Message-ID: <4862480.RxOcpDe54A@ralph.baldwin.cx>
User-Agent: KMail/4.14.10 (FreeBSD/11.0-PRERELEASE; KDE/4.14.10; amd64; ; )
In-Reply-To: <201610301556.u9UFuhAi009407@repo.freebsd.org>
References: <201610301556.u9UFuhAi009407@repo.freebsd.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3
 (mail.baldwin.cx); Sun, 30 Oct 2016 18:07:38 -0400 (EDT)
X-Virus-Scanned: clamav-milter 0.99.2 at mail.baldwin.cx
X-Virus-Status: Clean
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 30 Oct 2016 22:07:47 -0000

On Sunday, October 30, 2016 03:56:43 PM Li-Wen Hsu wrote:
> Author: lwhsu (ports committer)
> Date: Sun Oct 30 15:56:42 2016
> New Revision: 308107
> URL: https://svnweb.freebsd.org/changeset/base/308107
> 
> Log:
>   - Fix `make` in sys/modules/bhnd
>   
>   Approved by:	landonf
>   Differential Revision:	https://reviews.freebsd.org/D7774

This is wrong.  bhnd_debug.h should not have '#include opt_global.h'.  It is
included implicitly during kernel builds via '-include' in CFLAGS.  It is
always incorrect to include it explicitly in source.  This should be
reverted and bhnd_debug.h should be fixed instead.

-- 
John Baldwin