From owner-freebsd-bugs@freebsd.org Sat Nov 10 18:40:40 2018 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2FA89110668A for ; Sat, 10 Nov 2018 18:40:40 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 9E1E475E7A for ; Sat, 10 Nov 2018 18:40:39 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 630BB1106689; Sat, 10 Nov 2018 18:40:39 +0000 (UTC) Delivered-To: bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 410B11106688 for ; Sat, 10 Nov 2018 18:40:39 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B9A5775E73 for ; Sat, 10 Nov 2018 18:40:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id D218D677 for ; Sat, 10 Nov 2018 18:40:37 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id wAAIebb9007538 for ; Sat, 10 Nov 2018 18:40:37 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id wAAIeb32007537 for bugs@FreeBSD.org; Sat, 10 Nov 2018 18:40:37 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 233113] bectl activate fails to set canmount=noauto for old boot environment Date: Sat, 10 Nov 2018 18:40:37 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 12.0-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: asomers@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-Rspamd-Queue-Id: 9E1E475E7A X-Spamd-Result: default: False [-105.87 / 200.00]; FORGED_RECIPIENTS_FORWARDING(0.00)[]; ALLOW_DOMAIN_WHITELIST(-100.00)[freebsd.org]; FORWARDED(0.00)[bugs@mailman.ysv.freebsd.org]; SPF_FAIL_FORWARDING(0.00)[]; TO_DN_NONE(0.00)[]; HAS_XAW(0.00)[]; R_SPF_SOFTFAIL(0.00)[~all]; XAW_SERVICE_ACCT(1.00)[]; RCVD_IN_DNSWL_MED(-0.20)[5.0.0.0.0.5.0.0.0.0.0.0.0.0.0.0.a.6.0.2.4.5.2.2.0.0.9.1.1.0.0.2.list.dnswl.org : 127.0.9.2]; MX_GOOD(-0.01)[cached: mx66.freebsd.org]; NEURAL_HAM_SHORT(-1.00)[-1.000,0]; RCVD_NO_TLS_LAST(0.10)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; IP_SCORE(-3.66)[ip: (-9.82), ipnet: 2001:1900:2254::/48(-4.73), asn: 10310(-3.66), country: US(-0.09)]; ASN(0.00)[asn:10310, ipnet:2001:1900:2254::/48, country:US]; FORGED_RECIPIENTS(0.00)[bugs@FreeBSD.org,freebsd-bugs@freebsd.org]; TO_DOM_EQ_FROM_DOM(0.00)[]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[freebsd.org]; RCPT_COUNT_ONE(0.00)[1]; FROM_NO_DN(0.00)[]; RCVD_COUNT_SEVEN(0.00)[7] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 10 Nov 2018 18:40:40 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D233113 Bug ID: 233113 Summary: bectl activate fails to set canmount=3Dnoauto for old boot environment Product: Base System Version: 12.0-STABLE Hardware: Any OS: Any Status: New Severity: Affects Many People Priority: --- Component: bin Assignee: bugs@FreeBSD.org Reporter: asomers@FreeBSD.org "bectl activate" is supposed to set canmount=3Dauto for the old boot enviro= nment and set the pool's bootfs property to the new boot environment. That's what beadm does. However, bectl fails to clear canmount for the old boot environment. Observed on 12.0-BETA3 Example: somers@threonine /> bectl list BE Active Mountpoint Space Created 12.0-BETA4 NR / 9.45G 2018-11-10 10:09 12.0-BETA3 - - 1.52M 2018-11-08 09:35 12.0-CURRENT-up-20180401_231457 - - 38.0G 2018-04-01 23:13 12.0-CURRENT-up-20180327_233010 - - 13.2G 2018-03-27 23:28 somers@threonine /> zfs list -o name,mountpoint,canmount -r tank/ROOT NAME MOUNTPOINT CANMOUNT tank/ROOT none on tank/ROOT/12.0-BETA3 / noauto tank/ROOT/12.0-BETA4 / on tank/ROOT/12.0-CURRENT-up-20180327_233010 / noauto tank/ROOT/12.0-CURRENT-up-20180401_231457 / noauto somers@threonine /> sudo bectl create test somers@threonine /> sudo bectl activate test successfully activated boot environment test somers@threonine /> zpool get bootfs tank NAME PROPERTY VALUE SOURCE tank bootfs tank/ROOT/test local somers@threonine /> zfs list -o name,mountpoint,canmount -r tank/ROOT NAME MOUNTPOINT CANMOUNT tank/ROOT none on tank/ROOT/12.0-BETA3 / noauto tank/ROOT/12.0-BETA4 / on tank/ROOT/12.0-CURRENT-up-20180327_233010 / noauto tank/ROOT/12.0-CURRENT-up-20180401_231457 / noauto tank/ROOT/test / noauto !!!! 12.0-BETA4 still has CANMOUNT set to on !!!! But beadm has no problem here: somers@threonine /> sudo beadm activate 12.0-BETA4 Activated successfully somers@threonine /> sudo beadm destroy test Are you sure you want to destroy 'test'? This action cannot be undone (y/[n]): y Destroyed successfully somers@threonine /> zfs list -o name,mountpoint,canmount -r tank/ROOT NAME MOUNTPOINT CANMOUNT tank/ROOT none on tank/ROOT/12.0-BETA3 / noauto tank/ROOT/12.0-BETA4 / on tank/ROOT/12.0-CURRENT-up-20180327_233010 / noauto tank/ROOT/12.0-CURRENT-up-20180401_231457 / noauto somers@threonine /> sudo beadm create test Created successfully somers@threonine /> sudo beadm activate test Activated successfully somers@threonine /> zpool get bootfs tank NAME PROPERTY VALUE SOURCE tank bootfs tank/ROOT/test local somers@threonine /> zfs list -o name,mountpoint,canmount -r tank/ROOT NAME MOUNTPOINT CANMOUNT tank/ROOT none on tank/ROOT/12.0-BETA3 / noauto tank/ROOT/12.0-BETA4 / noauto tank/ROOT/12.0-CURRENT-up-20180327_233010 / noauto tank/ROOT/12.0-CURRENT-up-20180401_231457 / noauto tank/ROOT/test / noauto This bug renders the new boot environment unbootable, because two root filesystems get mounted, making devfs invisible. So it's a pretty critical bug. --=20 You are receiving this mail because: You are the assignee for the bug.=