Date: Mon, 21 Aug 2017 13:55:18 +0000 From: Antoine Brodin <antoine@freebsd.org> To: David Chisnall <theraven@freebsd.org> Cc: "ports-committers@freebsd.org" <ports-committers@freebsd.org>, "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>, "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org> Subject: Re: svn commit: r448472 - in head: Mk/Uses archivers/freetar archivers/unarchiver archivers/zipper audio/cddb-bundle audio/gnustep-cdplayer audio/mpdcon biology/biococoa databases/fortytwo-bdb database... Message-ID: <CAALwa8n3Rv9aY9-1CEt0qei8DNYeNQPeOA72VDgUzzcM-e0YjQ@mail.gmail.com> In-Reply-To: <CAALwa8k6YBA=aN9O4oy5NN3wqSs4USdfhT37W8Tg1FkF_n7K4w@mail.gmail.com> References: <201708211326.v7LDQTpS021179@repo.freebsd.org> <CAALwa8k6YBA=aN9O4oy5NN3wqSs4USdfhT37W8Tg1FkF_n7K4w@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Aug 21, 2017 at 1:42 PM, Antoine Brodin <antoine@freebsd.org> wrote: > On Mon, Aug 21, 2017 at 1:26 PM, David Chisnall <theraven@freebsd.org> wrote: >> Author: theraven >> Date: Mon Aug 21 13:26:28 2017 >> New Revision: 448472 >> URL: https://svnweb.freebsd.org/changeset/ports/448472 >> >> Log: >> Update GNUstep core libraries. >> >> Update the default Objective-C compiler. >> >> Fix various build failures in GNUstep ports from newer versions of the GNUstep >> core libraries and from changes to GNUstep Make. >> >> Update various ports that use GNUstep and bump the portrevision of the ones >> that haven't had a new release. > ... >> Modified: head/Mk/Uses/objc.mk >> ============================================================================== >> --- head/Mk/Uses/objc.mk Mon Aug 21 13:14:02 2017 (r448471) >> +++ head/Mk/Uses/objc.mk Mon Aug 21 13:26:28 2017 (r448472) > ... >> -# We do always need clang >> -.if ${COMPILER_TYPE} != clang >> -.if ${ALT_COMPILER_TYPE} == clang >> +# We do always need clang and prefer a recent version >> +.if (${COMPILER_TYPE} == clang && ${COMPILER_VERSION} < ${OBJC_CLANG_VERSION}) || ${COMPILER_TYPE} != clang > > Hi, > > The condition for the compiler version seems reversed? I misread the double-if. Cheers, Antoine
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAALwa8n3Rv9aY9-1CEt0qei8DNYeNQPeOA72VDgUzzcM-e0YjQ>