From owner-freebsd-questions Mon Jan 21 23:36:50 2002 Delivered-To: freebsd-questions@freebsd.org Received: from guru.mired.org (dsl-64-192-6-133.telocity.com [64.192.6.133]) by hub.freebsd.org (Postfix) with SMTP id 15DD337B416 for ; Mon, 21 Jan 2002 23:36:47 -0800 (PST) Received: (qmail 4290 invoked by uid 100); 22 Jan 2002 07:36:45 -0000 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <15437.5772.965984.619017@guru.mired.org> Date: Tue, 22 Jan 2002 01:36:44 -0600 To: Cliff Sarginson Cc: questions@freebsd.org Subject: Re: What do I do with changes to a kernel module ? In-Reply-To: <91790610@toto.iv> X-Mailer: VM 6.90 under 21.1 (patch 14) "Cuyahoga Valley" XEmacs Lucid X-face: "5Mnwy%?j>IIV\)A=):rjWL~NB2aH[}Yq8Z=u~vJ`"(,&SiLvbbz2W`;h9L,Yg`+vb1>RG% *h+%X^n0EZd>TM8_IB;a8F?(Fb"lw'IgCoyM.[Lg#r\ From: "Mike Meyer" X-Delivery-Agent: TMDA/0.44 (Python 2.2; freebsd-4.4-STABLE-i386) Sender: owner-freebsd-questions@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Cliff Sarginson types: > I have put some code into the USB Scanner modules source code to > add support for Epson 640 USB Scanners. > What do I do with it now to get it put in the distribution ? > > It's in 4.5 RC. > > Tough one that, all 6 lines of it :) Do a "diff -u" with the sources, and submit a PR with a subject that starts "[PATCH]". That in the subject line will clue in committers that you have included a patch to fix the problem, so they don't have to do anything but test your code and commit it. Oh, yeah - if you haven't followed style(9), read it and do so before submitting the PR. And yes, having become one of Anthony's "few, isolated cases" you get to call yourself a kernel hacker (jg) now. You don't have to be able to debug device drivers just by looking at the code. That is a truly rare talent, as most of us require a working sample device to do that. http://www.mired.org/home/mwm/ Independent WWW/Perforce/FreeBSD/Unix consultant, email for more information. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-questions" in the body of the message