From owner-p4-projects@FreeBSD.ORG Sun Jul 26 22:23:55 2009 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 28C961065672; Sun, 26 Jul 2009 22:23:55 +0000 (UTC) Delivered-To: perforce@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D0A7D106564A for ; Sun, 26 Jul 2009 22:23:54 +0000 (UTC) (envelope-from syl@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id BF4AB8FC19 for ; Sun, 26 Jul 2009 22:23:54 +0000 (UTC) (envelope-from syl@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id n6QMNsiC062520 for ; Sun, 26 Jul 2009 22:23:54 GMT (envelope-from syl@FreeBSD.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.14.3/8.14.3/Submit) id n6QMNs1A062518 for perforce@freebsd.org; Sun, 26 Jul 2009 22:23:54 GMT (envelope-from syl@FreeBSD.org) Date: Sun, 26 Jul 2009 22:23:54 GMT Message-Id: <200907262223.n6QMNs1A062518@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to syl@FreeBSD.org using -f From: Sylvestre Gallon To: Perforce Change Reviews Cc: Subject: PERFORCE change 166601 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 26 Jul 2009 22:23:56 -0000 http://perforce.freebsd.org/chv.cgi?CH=166601 Change 166601 by syl@syl_twoflowers on 2009/07/26 22:22:59 - add generic symbols Affected files ... .. //depot/projects/soc2009/syl_usb/hps_report/GenericCode.tex#2 edit Differences ... ==== //depot/projects/soc2009/syl_usb/hps_report/GenericCode.tex#2 (text+ko) ==== @@ -51,13 +51,47 @@ - xxxdci\_init - xxxdci\_uninit + + - xxxdci\_device\_done + - xxxdci\_start\_standard\_chain + Concerning clock\_on, clock\_off, pull\_up, pull\_down, wakeup\_peer can be a little bit factorised. A big part of this function do not move we can create a generic function called directly after or before Hardware changes. Perhaps there is also something that could be factorised in xxxdci\_uninit if there are not other possible access that interrupt disabling in it. + There are pehaps something to do with xxxdci\_device\_done and xxxdci\_start\_standard\_chain + beacuse the only hardware code present int this function just enable Endpoint interrupt. + \section{Hardware Independant Code} + - xxxdci\_ep\_init + + - xxxdci\_xfer\_setup + + - xxxdci\_roothub\_exec + + - All the HUB descriptor code + + - xxxdci\_device\_XXX\_methods + + - xxxdci\_standard\_done + + - xxxdci\_standard\_done\_sub + + - xxxdci\_root\_intr + + - xxxdci\_timeout + + - xxxdci\_setup\_standard\_chain + - xxxdci\_setup\_standard\_chain\_sub + + - xxxdci\_vbus\_interrupt + + - xxxdci\_interrupt\_poll + + - xxxdci\_xfer\_do\_fifo +