From owner-freebsd-current@freebsd.org Sun Jun 3 13:30:58 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A5DF2F7E1BA for ; Sun, 3 Jun 2018 13:30:58 +0000 (UTC) (envelope-from ler@lerctr.org) Received: from thebighonker.lerctr.org (thebighonker.lerctr.org [IPv6:2001:470:1f0f:3ad:bb:dcff:fe50:d900]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.lerctr.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48956854B9; Sun, 3 Jun 2018 13:30:58 +0000 (UTC) (envelope-from ler@lerctr.org) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lerctr.org; s=lerami; h=Content-type:Mime-version:In-Reply-To:References:Message-ID:CC: To:From:Subject:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=2LpcuLjnrinqR4nURMe5TqUOVGUy0zUsFfbapfuDd18=; b=Qd6jcBnrrsBiSHDPu/DWenQ40m i4EJyEXISvLWZDYfMsTgyseDAW+GhXwcFQxpLyhzQNg79m6ev7aDAJ4aWsdQADzn8XyS9fLPnZ+k4 HbPedmfR2cwef2KzYscQT5uyTm7wdyqq22N4EU4ZSwpTnf4lokE27GLWJ5K+T/On/fu8=; Received: from [2600:1700:210:b18f:3c8b:5e5:f3d8:df46] (port=60944 helo=[192.168.200.50]) by thebighonker.lerctr.org with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91 (FreeBSD)) (envelope-from ) id 1fPT60-000A55-5l; Sun, 03 Jun 2018 08:30:56 -0500 User-Agent: Microsoft-MacOutlook/10.f.0.180530 Date: Sun, 03 Jun 2018 08:30:54 -0500 Subject: Re: Error build nvidia-driver with r334555 From: Larry Rosenman To: Mateusz Guzik , CC: FreeBSD Current , , Mateusz Guzik , Alexey Dokuchaev Message-ID: <8E820581-3359-4EBA-8C82-6B35638E9920@lerctr.org> Thread-Topic: Error build nvidia-driver with r334555 References: <83fec8d8-699f-e86c-9884-9d8698a86a91@gmail.com> <20180603214222.953748e1eb7a0b39e11214ae@dec.sakura.ne.jp> In-Reply-To: Mime-version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.26 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 Jun 2018 13:30:58 -0000 sysutils/lsof fixed in r471495. Thanks, Mateusz! -- Larry Rosenman http://www.lerctr.org/~ler Phone: +1 214-642-9640 E-Mail: ler@lerctr.org US Mail: 5708 Sabbia Drive, Round Rock, TX 78665-2106 From: Mateusz Guzik Date: Sunday, June 3, 2018 at 8:20 AM To: Cc: "freebsd-current@freebsd.org" , , Mateusz Guzik , Alexey Dokuchaev , Subject: Re: Error build nvidia-driver with r334555 On Sun, Jun 3, 2018 at 2:42 PM, Tomoaki AOKI wrote: This is caused by r334533 and/or r334534 (memset-related changes). sysutils/lsof is also affected. You should revert r334533 and r334534 temporarily until nvidia-driver support this change. CC'ing the revision author and maintainers of both ports. Support in what sense? The error message clearly indicates a bug in the driver (also trivially fixable). Is there a problem adding a patch to files/? diff -ru src.orig/nvidia/nvidia_subr.c src/nvidia/nvidia_subr.c --- src.orig/nvidia/nvidia_subr.c 2018-06-03 13:19:56.490480000 +0000 +++ src/nvidia/nvidia_subr.c 2018-06-03 13:21:15.289344000 +0000 @@ -364,7 +364,7 @@ } ci = args; - memset(ci, 0, sizeof(ci)); + memset(ci, 0, sizeof(*ci)); for (i = 0; i < NV_MAX_DEVICES; i++) { sc = devclass_get_softc(nvidia_devclass, i); As for lsof: --- dlsof.h.orig 2018-06-03 13:16:14.712701000 +0000 +++ dlsof.h 2018-06-03 13:17:15.042655000 +0000 @@ -489,6 +489,12 @@ # endif /* FREEBSDV>=2020 */ #undef bzero /* avoid _KERNEL conflict */ +#undef bcmp +#undef bcopy +#undef memcmp +#undef memmove +#undef memcpy +#undef memset #include -- Mateusz Guzik