Date: Tue, 30 Aug 2016 19:02:15 +0000 (UTC) From: Dimitry Andric <dim@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r305077 - in head: contrib/telnet/libtelnet usr.bin/newkey Message-ID: <201608301902.u7UJ2FIM012587@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: dim Date: Tue Aug 30 19:02:15 2016 New Revision: 305077 URL: https://svnweb.freebsd.org/changeset/base/305077 Log: Squelch clang 3.9.0 warnings about BASE (which is 32768) being converted to -32768 when it is used as an argument to mp_itom(), in both libtelnet and newkey. This code has been wrong since r26238 (!), so after almost 20 years it is rather useless to try to correct it. MFC after: 1 week Modified: head/contrib/telnet/libtelnet/pk.c head/usr.bin/newkey/generic.c Modified: head/contrib/telnet/libtelnet/pk.c ============================================================================== --- head/contrib/telnet/libtelnet/pk.c Tue Aug 30 18:27:31 2016 (r305076) +++ head/contrib/telnet/libtelnet/pk.c Tue Aug 30 19:02:15 2016 (r305077) @@ -164,7 +164,7 @@ genkeys(char *public, char *secret) MINT *pk = mp_itom(0); MINT *sk = mp_itom(0); MINT *tmp; - MINT *base = mp_itom(BASE); + MINT *base = mp_itom((short)BASE); MINT *root = mp_itom(PROOT); MINT *modulus = mp_xtom(HEXMODULUS); short r; Modified: head/usr.bin/newkey/generic.c ============================================================================== --- head/usr.bin/newkey/generic.c Tue Aug 30 18:27:31 2016 (r305076) +++ head/usr.bin/newkey/generic.c Tue Aug 30 19:02:15 2016 (r305077) @@ -82,7 +82,7 @@ genkeys(char *public, char *secret, char MINT *pk = mp_itom(0); MINT *sk = mp_itom(0); MINT *tmp; - MINT *base = mp_itom(BASE); + MINT *base = mp_itom((short)BASE); MINT *root = mp_itom(PROOT); MINT *modulus = mp_xtom(HEXMODULUS); short r;
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201608301902.u7UJ2FIM012587>