From owner-svn-ports-all@FreeBSD.ORG Mon Dec 30 11:51:52 2013 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 8AF9B73A; Mon, 30 Dec 2013 11:51:52 +0000 (UTC) Received: from forward13.mail.yandex.net (forward13.mail.yandex.net [IPv6:2a02:6b8:0:801::3]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 35D7815BF; Mon, 30 Dec 2013 11:51:52 +0000 (UTC) Received: from smtp14.mail.yandex.net (smtp14.mail.yandex.net [95.108.131.192]) by forward13.mail.yandex.net (Yandex) with ESMTP id 56F88141A4B; Mon, 30 Dec 2013 15:51:00 +0400 (MSK) Received: from smtp14.mail.yandex.net (localhost [127.0.0.1]) by smtp14.mail.yandex.net (Yandex) with ESMTP id B21F11B609D1; Mon, 30 Dec 2013 15:50:59 +0400 (MSK) Received: from 87.249.28.58.tel.ru (87.249.28.58.tel.ru [87.249.28.58]) by smtp14.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id LHD7q7xI4A-owFu0Wsq; Mon, 30 Dec 2013 15:50:58 +0400 (using TLSv1 with cipher CAMELLIA256-SHA (256/256 bits)) (Client certificate not present) X-Yandex-Uniq: 35b5a24c-7f14-46d7-b167-af96b268b4ea Message-ID: <52C15E22.50700@passap.ru> Date: Mon, 30 Dec 2013 15:50:58 +0400 From: Boris Samorodov User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 MIME-Version: 1.0 To: Mathieu Arnold , Boris Samorodov , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r338091 - head/x11-servers/xorg-server References: <201312301141.rBUBfI9R099001@svn.freebsd.org> In-Reply-To: X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Dec 2013 11:51:52 -0000 30.12.2013 15:45, Mathieu Arnold пишет: > +--On 30 décembre 2013 11:41:18 +0000 Boris Samorodov > wrote: > | Author: bsam > | Date: Mon Dec 30 11:41:18 2013 > | New Revision: 338091 > | URL: http://svnweb.freebsd.org/changeset/ports/338091 > | > | Log: > | Fix PLIST_SUB (add a space after @comment) for non-default option. > | > | Reported and tested by: Andrea Venturoli > | Approved by: x11 (kwm) > | > | Modified: > | head/x11-servers/xorg-server/Makefile > | > | Modified: head/x11-servers/xorg-server/Makefile > | ========================================================================= > | ===== --- head/x11-servers/xorg-server/Makefile Mon Dec 30 11:40:41 2013 > | (r338090) +++ head/x11-servers/xorg-server/Makefile Mon Dec 30 11:41:18 > | 2013 (r338091) @@ -111,7 +111,7 @@ > | CONFIGURE_ARGS+=--enable-install-setuid= > | PLIST_SUB+= SUID="" > | .else > | CONFIGURE_ARGS+=--enable-install-setuid=no > | -PLIST_SUB+= SUID="@comment" > | +PLIST_SUB+= SUID="@comment " > | .endif > > You could do without the PLIST_SUB+= (and the bugs that comes with them) > with OPTIONS_SUB=yes which will give you a PLIST_SUB for each OPTIONS. Thanks for pointing this out. Well, my intention was just to do a tiny patch that fix a build. Other changes were not intended. -- WBR, Boris Samorodov (bsam) FreeBSD Committer, http://www.FreeBSD.org The Power To Serve