From owner-svn-src-stable-12@freebsd.org Sun Nov 18 02:53:15 2018 Return-Path: Delivered-To: svn-src-stable-12@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CA27A11243DD; Sun, 18 Nov 2018 02:53:15 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 196398E4EB; Sun, 18 Nov 2018 02:53:14 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1]) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id wAI2rCHI054182; Sat, 17 Nov 2018 18:53:12 -0800 (PST) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: (from freebsd@localhost) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id wAI2rCR5054181; Sat, 17 Nov 2018 18:53:12 -0800 (PST) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201811180253.wAI2rCR5054181@pdx.rh.CN85.dnsmgr.net> Subject: Re: svn commit: r340511 - stable/12/sys/kern In-Reply-To: <20181117235144.GA2799@raichu> To: Mark Johnston Date: Sat, 17 Nov 2018 18:53:12 -0800 (PST) CC: rgrimes@freebsd.org, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-12@freebsd.org Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 196398E4EB X-Spamd-Result: default: False [1.37 / 15.00]; ARC_NA(0.00)[]; HAS_REPLYTO(0.00)[rgrimes@freebsd.org]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_SPAM_SHORT(0.50)[0.500,0]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[dnsmgr.net]; REPLYTO_DOM_NEQ_FROM_DOM(0.00)[]; AUTH_NA(1.00)[]; RCPT_COUNT_FIVE(0.00)[6]; RCVD_COUNT_THREE(0.00)[3]; IP_SCORE(-0.02)[country: US(-0.10)]; MX_GOOD(-0.01)[cached: pdx.rh.CN85.dnsmgr.net]; R_SPF_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:13868, ipnet:69.59.192.0/19, country:US]; MID_RHS_MATCH_FROM(0.00)[] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: svn-src-stable-12@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for only the 12-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Nov 2018 02:53:16 -0000 > On Sat, Nov 17, 2018 at 03:47:16PM -0800, Rodney W. Grimes wrote: > > > Author: markj > > > Date: Sat Nov 17 20:01:35 2018 > > > New Revision: 340511 > > > URL: https://svnweb.freebsd.org/changeset/base/340511 > > > > > > Log: > > > MFC r339731: > > > Add FALLTHROUGH comments to appease Coverity. > > > > > > Modified: > > > stable/12/sys/kern/kern_environment.c > > > stable/12/sys/kern/vfs_mount.c > > > Directory Properties: > > > stable/12/ (props changed) > > > > > > Modified: stable/12/sys/kern/kern_environment.c > > > ============================================================================== > > > --- stable/12/sys/kern/kern_environment.c Sat Nov 17 20:00:10 2018 (r340510) > > > +++ stable/12/sys/kern/kern_environment.c Sat Nov 17 20:01:35 2018 (r340511) > > > @@ -839,10 +839,13 @@ getenv_quad(const char *name, quad_t *data) > > > switch (vtp[0]) { > > > case 't': case 'T': > > > iv *= 1024; > > > + /* FALLTHROUGH */ > > > case 'g': case 'G': > > > iv *= 1024; > > > + /* FALLTHROUGH */ > > > case 'm': case 'M': > > > iv *= 1024; > > > + /* FALLTHROUGH */ > > > case 'k': case 'K': > > > iv *= 1024; > > Missing /* FALLTHROUGH */ ?? > > The statement following "case '\0':" is a break. > > > > > > case '\0': > > > > And a refactor: > > > > case 't': case 'T': > > case 'g': case 'G': > > case 'm': case 'M': > > case 'k': case 'K': > > iv *= 1024; > > /* FALLTHROUGH */ > > case '\0': > > > > Isnt that the same functionality? > > No, it isn't. Gag, for some reason I was reading iv *=1024 as *iv = 1024, I need more sleep :-( -- Rod Grimes rgrimes@freebsd.org