From owner-svn-src-all@FreeBSD.ORG Tue Jan 6 09:35:10 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 3BEFBA7; Tue, 6 Jan 2015 09:35:10 +0000 (UTC) Received: from mail.turbocat.net (heidi.turbocat.net [88.198.202.214]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id EE27866468; Tue, 6 Jan 2015 09:35:09 +0000 (UTC) Received: from laptop015.home.selasky.org (cm-176.74.213.204.customer.telag.net [176.74.213.204]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.turbocat.net (Postfix) with ESMTPSA id 2E29D1FE022; Tue, 6 Jan 2015 10:35:06 +0100 (CET) Message-ID: <54ABAC7A.6080002@selasky.org> Date: Tue, 06 Jan 2015 10:35:54 +0100 From: Hans Petter Selasky User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Craig Rodrigues , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r276747 - head/sys/netpfil/pf References: <201501060903.t06934qp081875@svn.freebsd.org> In-Reply-To: <201501060903.t06934qp081875@svn.freebsd.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Jan 2015 09:35:10 -0000 On 01/06/15 09:39, Craig Rodrigues wrote:> Author: rodrigc > Date: Tue Jan 6 08:39:06 2015 > New Revision: 276746 > URL: https://svnweb.freebsd.org/changeset/base/276746 > > Log: > Merge: r258322 from projects/pf branch > > Split functions that initialize various pf parts into their > vimage parts and global parts. > Since global parts appeared to be only mutex initializations, just > abandon them and use MTX_SYSINIT() instead. > Kill my incorrect VNET_FOREACH() iterator and instead use correct > approach with VNET_SYSINIT(). > > PR: 194515 > Differential Revision: D1309 > Submitted by: glebius, Nikos Vassiliadis > Reviewed by: trociny, zec, gnn This results in the following build failures: sys/modules/pf/../../netpfil/pf/pf_ioctl.c:3728:3: error: use of undeclared identifier 'V_pf_end_threads' V_pf_end_threads = 0; ^ sys/modules/pf/../../netpfil/pf/pf_ioctl.c:3815:6: error: use of undeclared identifier 'vnet_pf_init' vnet_pf_init, NULL); ^ sys/net/vnet.h:414:35: note: expanded from macro 'VNET_SYSINIT' SYSINIT(ident, subsystem, order, func, arg) ^ sys/sys/kernel.h:243:36: note: expanded from macro 'SYSINIT' (sysinit_cfunc_t)(sysinit_nfunc_t)func, (void *)(ident)) ^ sys/sys/kernel.h:236:3: note: expanded from macro 'C_SYSINIT' func --HPS