Date: Sun, 5 Feb 2023 15:51:45 +0800 From: Po-Chuan Hsieh <sunpoet@freebsd.org> To: Muhammad Moinur Rahman <bofh@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 9ba756b0e950 - main - graphics/gdal-grass: Fix PORTVERSION going backwords Message-ID: <CAMHz58QH1zr0A1DqAwq8a2dC1zd9y-8vrcTcs-2tnR89RyxrYA@mail.gmail.com> In-Reply-To: <202301311256.30VCus3M012261@gitrepo.freebsd.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Tue, Jan 31, 2023 at 8:56 PM Muhammad Moinur Rahman <bofh@freebsd.org> wrote: > The branch main has been updated by bofh: > > URL: > https://cgit.FreeBSD.org/ports/commit/?id=9ba756b0e950d76c63a291797407abd9972d1eb2 > > commit 9ba756b0e950d76c63a291797407abd9972d1eb2 > Author: Muhammad Moinur Rahman <bofh@FreeBSD.org> > AuthorDate: 2023-01-31 12:55:14 +0000 > Commit: Muhammad Moinur Rahman <bofh@FreeBSD.org> > CommitDate: 2023-01-31 12:56:47 +0000 > > graphics/gdal-grass: Fix PORTVERSION going backwords > > This port was resurrected with an older version than it was in the tree > while removal. Hence it requires PORTEPOCH. > Thanks for your help but the fix is incorrect. It is unreasonable to add PORTEPOCH when the previous one was removed over 7 years ago (Nov 1, 2015) [1]. No one would be affected with this version. The PORTVERSION check is great. It helps people to keep ports/pkg up-to-date (from one *installed* version to another). IMHO, the correct fix is to clean up the version db regularly. We could expire removed ports after a period of time. Thanks. [1] https://cgit.freebsd.org/ports/commit/?id=5e1001eeb3e8c92ec3453e2cee94a870ee99ed86 > Approved by: portmgr (just-fix-it) > --- > graphics/gdal-grass/Makefile | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/graphics/gdal-grass/Makefile b/graphics/gdal-grass/Makefile > index cdb9ff57bb33..fc09da52da9c 100644 > --- a/graphics/gdal-grass/Makefile > +++ b/graphics/gdal-grass/Makefile > @@ -1,5 +1,6 @@ > PORTNAME= gdal-grass > PORTVERSION= 1.0.2 > +PORTEPOCH= 1 > CATEGORIES= graphics > > MAINTAINER= sunpoet@FreeBSD.org > > [-- Attachment #2 --] <div dir="ltr"><div dir="ltr">On Tue, Jan 31, 2023 at 8:56 PM Muhammad Moinur Rahman <<a href="mailto:bofh@freebsd.org">bofh@freebsd.org</a>> wrote:<br></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">The branch main has been updated by bofh:<br> <br> URL: <a href="https://cgit.FreeBSD.org/ports/commit/?id=9ba756b0e950d76c63a291797407abd9972d1eb2" rel="noreferrer" target="_blank">https://cgit.FreeBSD.org/ports/commit/?id=9ba756b0e950d76c63a291797407abd9972d1eb2</a><br>; <br> commit 9ba756b0e950d76c63a291797407abd9972d1eb2<br> Author: Muhammad Moinur Rahman <bofh@FreeBSD.org><br> AuthorDate: 2023-01-31 12:55:14 +0000<br> Commit: Muhammad Moinur Rahman <bofh@FreeBSD.org><br> CommitDate: 2023-01-31 12:56:47 +0000<br> <br> graphics/gdal-grass: Fix PORTVERSION going backwords<br> <br> This port was resurrected with an older version than it was in the tree<br> while removal. Hence it requires PORTEPOCH.<br></blockquote><div><br></div><div>Thanks for your help but the fix is incorrect.</div><div>It is unreasonable to add PORTEPOCH when the previous one was removed over 7 years ago (Nov 1, 2015) [1].</div><div>No one would be affected with this version.</div><div><br></div><div>The PORTVERSION check is great.</div><div>It helps people to keep ports/pkg up-to-date (from one *installed* version to another).</div><div></div><div>IMHO, the correct fix is to clean up the version db regularly.</div><div>We could expire removed ports after a period of time.</div><div><br></div><div>Thanks.</div><div><br></div><div>[1] <a href="https://cgit.freebsd.org/ports/commit/?id=5e1001eeb3e8c92ec3453e2cee94a870ee99ed86">https://cgit.freebsd.org/ports/commit/?id=5e1001eeb3e8c92ec3453e2cee94a870ee99ed86</a></div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> <br> Approved by: portmgr (just-fix-it)<br> ---<br> graphics/gdal-grass/Makefile | 1 +<br> 1 file changed, 1 insertion(+)<br> <br> diff --git a/graphics/gdal-grass/Makefile b/graphics/gdal-grass/Makefile<br> index cdb9ff57bb33..fc09da52da9c 100644<br> --- a/graphics/gdal-grass/Makefile<br> +++ b/graphics/gdal-grass/Makefile<br> @@ -1,5 +1,6 @@<br> PORTNAME= gdal-grass<br> PORTVERSION= 1.0.2<br> +PORTEPOCH= 1<br> CATEGORIES= graphics<br> <br> MAINTAINER= sunpoet@FreeBSD.org<br> <br> </blockquote></div></div>home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAMHz58QH1zr0A1DqAwq8a2dC1zd9y-8vrcTcs-2tnR89RyxrYA>