From owner-cvs-src@FreeBSD.ORG Sat Nov 18 18:51:01 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id EDCF516A416; Sat, 18 Nov 2006 18:51:01 +0000 (UTC) (envelope-from bde@zeta.org.au) Received: from mailout2.pacific.net.au (mailout2-3.pacific.net.au [61.8.2.226]) by mx1.FreeBSD.org (Postfix) with ESMTP id CC66A43D76; Sat, 18 Nov 2006 18:48:10 +0000 (GMT) (envelope-from bde@zeta.org.au) Received: from mailproxy1.pacific.net.au (mailproxy1.pacific.net.au [61.8.2.162]) by mailout2.pacific.net.au (Postfix) with ESMTP id 7D4D910D177; Sun, 19 Nov 2006 05:47:42 +1100 (EST) Received: from katana.zip.com.au (katana.zip.com.au [61.8.7.246]) by mailproxy1.pacific.net.au (Postfix) with ESMTP id BB0048C09; Sun, 19 Nov 2006 05:47:41 +1100 (EST) Date: Sun, 19 Nov 2006 05:47:40 +1100 (EST) From: Bruce Evans X-X-Sender: bde@delplex.bde.org To: "M. Warner Losh" In-Reply-To: <20061118.110343.58444366.imp@bsdimp.com> Message-ID: <20061119052526.S16985@delplex.bde.org> References: <20061117201432.X11101@delplex.bde.org> <20061117.105304.1769993002.imp@bsdimp.com> <20061118214618.U15111@delplex.bde.org> <20061118.110343.58444366.imp@bsdimp.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: src-committers@freebsd.org, yar@comp.chem.msu.su, cvs-all@freebsd.org, phk@phk.freebsd.dk, cvs-src@freebsd.org, jkoshy@freebsd.org Subject: Re: cvs commit: src/include ar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Nov 2006 18:51:02 -0000 On Sat, 18 Nov 2006, M. Warner Losh wrote: > In message: <20061118214618.U15111@delplex.bde.org> > Bruce Evans writes: > : On Fri, 17 Nov 2006, M. Warner Losh wrote: > : > : > In message: <20061117201432.X11101@delplex.bde.org> > : > Bruce Evans writes: > : > : For that the comment should be something like: > : > : > : > : __packed; /* Align (sic) to work around bugs on arm (*). */ > : > : > : > : but I doubt that arm is that broken. > : > : > : > : (*) See this thread for more details. > : > > : > But they aren't bugs. > : > : Er, this thread gived the details of why they are bugs. > > Wait, is this the ar or the struct ip thing.. Ar is clearly needed, > but I was going to test the packedness on struct ip... I've just had > my first son and am operating on too little sleep :-(. I was mostly talking about struct ip. Something is needed for struct ar_hdr, since although it has size a multiple of 4 applications expect it to have alignment 1 but arm gives it alignment 4. Something is needed for struct ether_header (which sam recently packed), since it wants to have size 14 and alignment 2, but arm gives it size 16 and alignment 4. Nothing shoulded be need for struct ip, since it wants to have size 20 and alignment 4, and arm gives it that. struct ether header now has alignment 1. I don't like that... Immediately after struct ether_header in , there is struct ether_addr. This wants to have size 6 and alignment 1 (it wants to be just 6 octets), but is still unpacked so it has size 8 and alignment 4 on arm. It's surprising that anything in ethernet works on arm. Bruce