Date: Tue, 21 Jan 2014 17:02:49 -0700 From: Alan Somers <asomers@freebsd.org> To: Garrett Cooper <yaneurabeya@gmail.com> Cc: "freebsd-testing@freebsd.org" <freebsd-testing@freebsd.org> Subject: Re: PATCH: add ATF tests in sys Message-ID: <CAOtMX2goL4yvGjYZX8Gmk=rx0du5yrsQ_W-Y8XWo0WkCNDjwkw@mail.gmail.com> In-Reply-To: <C2E6F1D5-B409-4F2E-B856-C65473BCC3A0@gmail.com> References: <CAOtMX2iiSH9DvE73_7V=A%2ByqObROmvJu7VRTMG7K74eMtHk4=g@mail.gmail.com> <C2E6F1D5-B409-4F2E-B856-C65473BCC3A0@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Jan 21, 2014 at 4:56 PM, Garrett Cooper <yaneurabeya@gmail.com> wro= te: > >> On Jan 21, 2014, at 14:45, Alan Somers <asomers@freebsd.org> wrote: >> >> I rewrote the unix seqpacket tests in ATF. The hard part is adding >> them to the build. The linked patch adds them in the directory >> sys/kern/tests and builds them as part of buildworld, not buildkernel. >> They get installed to /usr/tests/sys/kern, but the intermediate >> objects are stored in /usr/obj/sys/kern/tests. That means that you >> can't have different tests associated with different kernel configs. >> I think that this is desirable, because you wouldn't be able to >> install tests for different kernel configs anyway, given our chosen >> layout of /usr/tests. >> >> Please comment on the parts of this patch that deal with Makefiles. >> Is this the appropriate way to add sys tests to the build? Shouldn't >> I be building them in buildkernel instead of buildworld? I couldn't >> find a good way to do that. > > I bypassed that for simplicity and placed the tests in tests/sys/kern/...= etc. Shoehorning things into our overly complex kernel build system just s= eems like a really bad idea... Just make it load as a driver, loadable, and= dependent on kern.features to run..? > Cheers! > -Garrett I tried to place the tests as closely as possible to the source code that they're testing, according to https://wiki.freebsd.org/TestSuite/Structure#Makefiles_for_test_programs . I don't feel strongly about it either way, but I think Simon and jmmv do. FWIW, the tests run as a userland program, not in kernel mode. -Alan
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAOtMX2goL4yvGjYZX8Gmk=rx0du5yrsQ_W-Y8XWo0WkCNDjwkw>