From owner-freebsd-ports-bugs@FreeBSD.ORG  Mon Mar 11 13:30:02 2013
Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG>
Delivered-To: freebsd-ports-bugs@smarthost.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by hub.freebsd.org (Postfix) with ESMTP id 0F831C28
 for <freebsd-ports-bugs@smarthost.ysv.freebsd.org>;
 Mon, 11 Mar 2013 13:30:02 +0000 (UTC)
 (envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 by mx1.freebsd.org (Postfix) with ESMTP id D2A07204
 for <freebsd-ports-bugs@smarthost.ysv.freebsd.org>;
 Mon, 11 Mar 2013 13:30:01 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
 by freefall.freebsd.org (8.14.6/8.14.6) with ESMTP id r2BDU10O019942
 for <freebsd-ports-bugs@freefall.freebsd.org>; Mon, 11 Mar 2013 13:30:01 GMT
 (envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
 by freefall.freebsd.org (8.14.6/8.14.6/Submit) id r2BDU1QP019941;
 Mon, 11 Mar 2013 13:30:01 GMT (envelope-from gnats)
Resent-Date: Mon, 11 Mar 2013 13:30:01 GMT
Resent-Message-Id: <201303111330.r2BDU1QP019941@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-ports-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org,
 Oleg Ginzburg <olevole@olevole.ru>
Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115])
 by hub.freebsd.org (Postfix) with ESMTP id 4CAB194E
 for <freebsd-gnats-submit@FreeBSD.org>; Mon, 11 Mar 2013 13:23:08 +0000 (UTC)
 (envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
 by mx1.freebsd.org (Postfix) with ESMTP id 3E6851AE
 for <freebsd-gnats-submit@FreeBSD.org>; Mon, 11 Mar 2013 13:23:08 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
 by red.freebsd.org (8.14.5/8.14.5) with ESMTP id r2BDN7hE034189
 for <freebsd-gnats-submit@FreeBSD.org>; Mon, 11 Mar 2013 13:23:07 GMT
 (envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
 by red.freebsd.org (8.14.5/8.14.5/Submit) id r2BDN7VP034188;
 Mon, 11 Mar 2013 13:23:07 GMT (envelope-from nobody)
Message-Id: <201303111323.r2BDN7VP034188@red.freebsd.org>
Date: Mon, 11 Mar 2013 13:23:07 GMT
From: Oleg Ginzburg <olevole@olevole.ru>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-3.1
Subject: ports/176849: empty variable optionsdir in bsd.port.mk
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-ports-bugs>, 
 <mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
 <mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 11 Mar 2013 13:30:02 -0000


>Number:         176849
>Category:       ports
>Synopsis:       empty variable optionsdir in bsd.port.mk
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Mar 11 13:30:01 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     Oleg Ginzburg
>Release:        10-current
>Organization:
>Environment:
>Description:
in the follow code:
@(optionsdir=${OPTIONSFILE}; optionsdir=$${optionsdir%/*};

optionsdir declate in subshell and not exported for using outside, for example in next follow code:

(${ECHO_MSG} "===> Cannot create $${optionsdir}, check permissions"; exit 1)

>How-To-Repeat:
Create conditions for mkdir fail, for example:

rm -rf /var/db/ports/redis
touch /var/db/ports/redis
make -C /usr/ports/databases/redis
===> Cannot create , check permissions
*** [do-config] Error code 1


Missing dir in "Cannot create" 
>Fix:


Patch attached with submission follows:

--- /usr/ports/Mk/bsd.port.mk.bak	2013-03-11 17:12:22.000000000 +0400
+++ /usr/ports/Mk/bsd.port.mk	2013-03-11 17:12:31.000000000 +0400
@@ -6142,8 +6142,8 @@
 		(${ECHO_MSG} "===> Cannot create $${optionsdir}, check permissions"; exit 1); \
 	${ECHO_MSG} "===>  Returning to user credentials"
 .else
-	@(optionsdir=${OPTIONSFILE}; optionsdir=$${optionsdir%/*}; \
-	${MKDIR} $${optionsdir} 2> /dev/null) || \
+	@optionsdir=${OPTIONSFILE}; optionsdir=$${optionsdir%/*}; \
+	${MKDIR} $${optionsdir} 2> /dev/null || \
 	(${ECHO_MSG} "===> Cannot create $${optionsdir}, check permissions"; exit 1)
 .endif
 	@TMPOPTIONSFILE=$$(mktemp -t portoptions); \


>Release-Note:
>Audit-Trail:
>Unformatted: