From owner-freebsd-current@FreeBSD.ORG Tue Feb 24 17:20:27 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CD67216A4CE; Tue, 24 Feb 2004 17:20:27 -0800 (PST) Received: from hak.cnd.mcgill.ca (hak.cnd.mcgill.ca [132.216.11.133]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5F1E043D2F; Tue, 24 Feb 2004 17:20:27 -0800 (PST) (envelope-from mat@hak.cnd.mcgill.ca) Received: from hak.cnd.mcgill.ca (localhost [127.0.0.1]) by hak.cnd.mcgill.ca (8.12.9/8.12.8) with ESMTP id i1P1MaCR061048; Tue, 24 Feb 2004 20:22:36 -0500 (EST) (envelope-from mat@hak.cnd.mcgill.ca) Received: (from mat@localhost) by hak.cnd.mcgill.ca (8.12.9/8.12.8/Submit) id i1P1MZDg061047; Tue, 24 Feb 2004 20:22:35 -0500 (EST) Date: Tue, 24 Feb 2004 20:22:35 -0500 From: Mathew Kanner To: Don Lewis Message-ID: <20040225012235.GN20226@cnd.mcgill.ca> References: <7mwu6dgn15.wl@black.imgsrc.co.jp> <200402241527.i1OFRC7E074338@gw.catspoiler.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200402241527.i1OFRC7E074338@gw.catspoiler.org> User-Agent: Mutt/1.4.1i Organization: I speak for myself, operating in Montreal, CANADA X-Spam-Status: No, hits=0.0 required=5.0 tests=none autolearn=no version=2.62 X-Spam-Checker-Version: SpamAssassin 2.62 (2004-01-11) on hak.cnd.mcgill.ca cc: kuriyama@imgsrc.co.jp cc: freebsd-current@FreeBSD.org cc: mat@cnd.mcgill.ca cc: cg@FreeBSD.org Subject: Re: exclusive sleep mutex pcm0 (sound cdev) r = 0 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Feb 2004 01:20:27 -0000 On Feb 24, Don Lewis wrote: > On 24 Feb, Jun Kuriyama wrote: > > > > I got this warning on my current box: > > > > malloc() of "256" with the following non-sleepable locks held: > > exclusive sleep mutex pcm0 (sound cdev) r = 0 (0xc73e63c0) locked @ dev/sound/pcm/dsp.c:213 > > > > I think there is no need to wait in vchan_create(). If kernel does > > not have resources to return small 256 bytes memory for sound device, > > we are not in the situation to care whether sound is played correctly > > or not... > > There are a bunch more problems with the "sound cdev" mutex, many of > which can't be fixed by this type of change unless having sporadic sound > system failures due to temporary malloc() failures is acceptable. > > I currently have some patches for the channel mutexes that are > undergoing testing. Once these have been committed, I'll take another > look at the "sound cdev" mutex. My current thought is to convert most > uses of it to a lockmgr lock. Don, I've only recently come up-to date with the freebsd-life and I plan to test your outstanding patches in the next day or so. I think before you take another you do another iteration of bug fixing we should re-consider vchans. (Although I think it may be wise at looking at fixing the buffer size and not allowing the re-allocation). Are you interested at looking at that first? --Mat -- In general, a standard is very useful, whether it's de facto or du jour. - Microsoft's Greg Sullivan as misquoted by News.Com