From owner-svn-src-head@freebsd.org  Tue May 10 15:02:53 2016
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 853FAB36553;
 Tue, 10 May 2016 15:02:53 +0000 (UTC) (envelope-from hps@selasky.org)
Received: from mail.turbocat.net (mail.turbocat.net
 [IPv6:2a01:4f8:d16:4514::2])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 521961F53;
 Tue, 10 May 2016 15:02:53 +0000 (UTC) (envelope-from hps@selasky.org)
Received: from laptop015.home.selasky.org (unknown [62.141.129.119])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by mail.turbocat.net (Postfix) with ESMTPSA id B1B8F1FE022;
 Tue, 10 May 2016 17:02:50 +0200 (CEST)
Subject: Re: svn commit: r299363 - head/sys/compat/linuxkpi/common/include/asm
To: Hans Petter Selasky <hselasky@FreeBSD.org>, src-committers@freebsd.org,
 svn-src-all@freebsd.org, svn-src-head@freebsd.org
References: <201605101139.u4ABdaTL098171@repo.freebsd.org>
From: Hans Petter Selasky <hps@selasky.org>
Message-ID: <7693af09-def2-e8a7-b7fd-9b6df41908cc@selasky.org>
Date: Tue, 10 May 2016 17:06:08 +0200
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101
 Thunderbird/45.0
MIME-Version: 1.0
In-Reply-To: <201605101139.u4ABdaTL098171@repo.freebsd.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 10 May 2016 15:02:53 -0000

On 05/10/16 13:39, Hans Petter Selasky wrote:
> Author: hselasky
> Date: Tue May 10 11:39:36 2016
> New Revision: 299363
> URL: https://svnweb.freebsd.org/changeset/base/299363
>
> Log:
>   Use function macros when possible to avoid stray substitutions.
>
>   MFC after:	1 week
>   Sponsored by:	Mellanox Technologies
>

FYI

This change accidentially broke LINT and I have a patch waiting for 
review from the Chelsio guys that will fix LINT and WITH_OFED=YES again. 
Will hopefully be fixed shortly.

> Index: sys/dev/cxgb/cxgb_osdep.h
> ===================================================================
> --- sys/dev/cxgb/cxgb_osdep.h	(revision 299261)
> +++ sys/dev/cxgb/cxgb_osdep.h	(working copy)
> @@ -169,7 +169,7 @@
>  #define test_and_clear_bit(bit, p) atomic_cmpset_int((p), ((*(p)) | (1<<bit)), ((*(p)) & ~(1<<bit)))
>
>  #define max_t(type, a, b) (type)max((a), (b))
> -#define cpu_to_be32            htobe32
> +#define cpu_to_be32(x)		htobe32(x)
>
>  /* Standard PHY definitions */
>  #define BMCR_LOOPBACK		BMCR_LOOP

--HPS