From nobody Thu May 16 21:18:54 2024 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VgNJ313ccz5KCZv; Thu, 16 May 2024 21:18:59 +0000 (UTC) (envelope-from yuri@FreeBSD.org) Received: from shell1.rawbw.com (shell1.rawbw.com [198.144.192.42]) by mx1.freebsd.org (Postfix) with ESMTP id 4VgNJ25R2Fz40dg; Thu, 16 May 2024 21:18:58 +0000 (UTC) (envelope-from yuri@FreeBSD.org) Authentication-Results: mx1.freebsd.org; none Received: from [192.168.5.3] (c-98-42-44-116.hsd1.ca.comcast.net [98.42.44.116]) (authenticated bits=0) by shell1.rawbw.com (8.15.1/8.15.1) with ESMTPSA id 44GLIugY095832 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO); Thu, 16 May 2024 14:18:56 -0700 (PDT) (envelope-from yuri@FreeBSD.org) X-Authentication-Warning: shell1.rawbw.com: Host c-98-42-44-116.hsd1.ca.comcast.net [98.42.44.116] claimed to be [192.168.5.3] Content-Type: multipart/alternative; boundary="------------TuwkhWcoN5j2deMvJpcIx77z" Message-ID: <681c0653-fead-4825-8451-7723c38882e2@FreeBSD.org> Date: Thu, 16 May 2024 14:18:54 -0700 List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-all@freebsd.org Sender: owner-dev-commits-ports-all@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: 5c97fbea8cb6 - main - *: Spell PORTREVISION correctly Content-Language: en-US To: Vladimir Druzenko , Yuri , Tobias Kortkamp Cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org References: <202405131305.44DD5p58063913@gitrepo.freebsd.org> <714f05a7-007a-4f16-991e-c53d36f9a083@freebsd.org> <1210af6d-2598-46d4-8115-ec2f2a5399fd@FreeBSD.org> <20db6508-cbba-409d-aaec-fdeb5d7e5a5d@freebsd.org> From: Yuri In-Reply-To: <20db6508-cbba-409d-aaec-fdeb5d7e5a5d@freebsd.org> X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:7961, ipnet:198.144.192.0/23, country:US] X-Rspamd-Queue-Id: 4VgNJ25R2Fz40dg This is a multi-part message in MIME format. --------------TuwkhWcoN5j2deMvJpcIx77z Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/16/24 14:02, Vladimir Druzenko wrote: > > Why not? 1. It would add a lot of unnecessary lines to Makefiles. 2. It is possible to check for such typos in git commit scripts and prevent bad commits like this. 3. portlint also checks for this. 4. It's not a wide-spread problem. Just identify who added typos and send them educational materials about Tools/scripts/bump-revision.sh, portlint, etc. Yuri --------------TuwkhWcoN5j2deMvJpcIx77z Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit
On 5/16/24 14:02, Vladimir Druzenko wrote:

Why not?

1. It would add a lot of unnecessary lines to Makefiles.
2. It is possible to check for such typos in git commit scripts and prevent bad commits like this.
3. portlint also checks for this.
4. It's not a wide-spread problem. Just identify who added typos and send them educational materials about Tools/scripts/bump-revision.sh, portlint, etc.



Yuri


--------------TuwkhWcoN5j2deMvJpcIx77z--