From owner-freebsd-current@FreeBSD.ORG Sat Mar 24 15:22:59 2007 Return-Path: X-Original-To: current@freebsd.org Delivered-To: freebsd-current@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 8CD9316A50E; Sat, 24 Mar 2007 15:22:59 +0000 (UTC) (envelope-from niclas.zeising@gmail.com) Received: from pne-smtpout2-sn2.hy.skanova.net (pne-smtpout2-sn2.hy.skanova.net [81.228.8.164]) by mx1.freebsd.org (Postfix) with ESMTP id 14E8B13C44C; Sat, 24 Mar 2007 15:22:59 +0000 (UTC) (envelope-from niclas.zeising@gmail.com) Received: from [90.224.61.75] (90.224.61.75) by pne-smtpout2-sn2.hy.skanova.net (7.2.075) id 45B620AA00F9BC82; Sat, 24 Mar 2007 15:13:55 +0100 Message-ID: <4605321E.50503@gmail.com> Date: Sat, 24 Mar 2007 15:13:50 +0100 From: Niclas Zeising User-Agent: Thunderbird 1.5.0.10 (Windows/20070221) MIME-Version: 1.0 To: FreeBSD Tinderbox References: <20070324133450.4C60D73039@freebsd-current.sentex.ca> In-Reply-To: <20070324133450.4C60D73039@freebsd-current.sentex.ca> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: current@freebsd.org, i386@freebsd.org Subject: Re: [head tinderbox] failure on i386/i386 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Mar 2007 15:22:59 -0000 FreeBSD Tinderbox wrote: [SNIP most of the build log] >>>> Kernel build for LINT started on Sat Mar 24 13:24:12 UTC 2007 >>>> stage 1: configuring the kernel >>>> stage 2.1: cleaning up the object tree >>>> stage 2.2: rebuilding the object tree >>>> stage 2.3: build tools >>>> stage 3.1: making dependencies >>>> stage 3.2: building everything > [...] > cc -c -O2 -pipe -fno-strict-aliasing -std=c99 -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -Wundef -fformat-extensions -nostdinc -I- -I. -I/src/sys -I/src/sys/contrib/altq -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h -fno-common -finline-limit=8000 --param inline-unit-growth=100 --param large-function-growth=1000 -DGPROF -falign-functions=16 -DGPROF4 -DGUPROF -fno-builtin -mno-align-long-strings -mpreferred-stack-boundary=2 -mno-mmx -mno-3dnow -mno-sse -mno-sse2 -mno-sse3 -ffreestanding -Werror -pg -mprofiler-epilogue /src/sys/netinet/tcp_hostcache.c > cc -c -O2 -pipe -fno-strict-aliasing -std=c99 -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -Wundef -fformat-extensions -nostdinc -I- -I. -I/src/sys -I/src/sys/contrib/altq -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h -fno-common -finline-limit=8000 --param inline-unit-growth=100 --param large-function-growth=1000 -DGPROF -falign-functions=16 -DGPROF4 -DGUPROF -fno-builtin -mno-align-long-strings -mpreferred-stack-boundary=2 -mno-mmx -mno-3dnow -mno-sse -mno-sse2 -mno-sse3 -ffreestanding -Werror -pg -mprofiler-epilogue /src/sys/netinet/tcp_input.c > /src/sys/netinet/tcp_input.c: In function `tcp_do_segment': > /src/sys/netinet/tcp_input.c:1275: error: `ostate' undeclared (first use in this function) > /src/sys/netinet/tcp_input.c:1275: error: (Each undeclared identifier is reported only once > /src/sys/netinet/tcp_input.c:1275: error: for each function it appears in.) > /src/sys/netinet/tcp_input.c:1276: error: `tcp_saveipgen' undeclared (first use in this function) > /src/sys/netinet/tcp_input.c:1276: error: `tcp_savetcp' undeclared (first use in this function) > *** Error code 1 > > Stop in /obj/src/sys/LINT. > *** Error code 1 > > Stop in /src. > *** Error code 1 > > Stop in /src. > TB --- 2007-03-24 13:34:50 - WARNING: /usr/bin/make returned exit code 1 > TB --- 2007-03-24 13:34:50 - ERROR: failed to build lint kernel > TB --- 2007-03-24 13:34:50 - tinderbox aborted > TB --- 0.53 user 2.02 system 4362.57 real > > > http://tinderbox.des.no/tinderbox-head-HEAD-i386-i386.full I've found the reason for this build breakage, and noted that it only affects kernels with TCPDEBUG. The issue is that ostadte , tcp_saveipgen and tcp_savetcp are declared at the top of tcp_input() , which was fine when tcp_input and tcp_do_segment() was one function. When tcp_input() was split, the declarations stayed, but the new tcp_do_segment() has references to them as well. Regards! //Niclas