From owner-freebsd-bugs@FreeBSD.ORG Thu Oct 4 09:20:04 2007 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3761316A46B for ; Thu, 4 Oct 2007 09:20:04 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id EEF0013C4B3 for ; Thu, 4 Oct 2007 09:20:03 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.1/8.14.1) with ESMTP id l949K3EB031647 for ; Thu, 4 Oct 2007 09:20:03 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.1/8.14.1/Submit) id l949K3cB031646; Thu, 4 Oct 2007 09:20:03 GMT (envelope-from gnats) Resent-Date: Thu, 4 Oct 2007 09:20:03 GMT Resent-Message-Id: <200710040920.l949K3cB031646@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, VANHULLEBUS Yvan Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 061D316A41A for ; Thu, 4 Oct 2007 09:18:51 +0000 (UTC) (envelope-from yvan.vanhullebus@netasq.com) Received: from netasq.netasq.com (netasq.netasq.com [213.30.137.178]) by mx1.freebsd.org (Postfix) with ESMTP id BBD8913C459 for ; Thu, 4 Oct 2007 09:18:50 +0000 (UTC) (envelope-from yvan.vanhullebus@netasq.com) Received: from darkstar.netasq.com (unknown [10.0.0.126]) by netasq.netasq.com (Postfix) with ESMTP id 02D4E6F06B for ; Thu, 4 Oct 2007 11:18:49 +0200 (CEST) Received: by darkstar.netasq.com (Postfix, from userid 1001) id D222FF74F8; Thu, 4 Oct 2007 11:18:48 +0200 (CEST) Message-Id: <20071004091848.D222FF74F8@darkstar.netasq.com> Date: Thu, 4 Oct 2007 11:18:48 +0200 (CEST) From: VANHULLEBUS Yvan To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: kern/116896: Typo in a kassert in GEOM X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: VANHULLEBUS Yvan List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Oct 2007 09:20:04 -0000 >Number: 116896 >Category: kern >Synopsis: Typo in a kassert in GEOM >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Thu Oct 04 09:20:02 GMT 2007 >Closed-Date: >Last-Modified: >Originator: VANHULLEBUS Yvan >Release: FreeBSD 6.2-STABLE i386 >Organization: NETASQ >Environment: System: FreeBSD darkstar.netasq.com 6.2-STABLE FreeBSD 6.2-STABLE #0: Mon Jan 22 14:18:45 CET 2007 root@darkstar.netasq.com:/usr/obj/usr/src/sys/GENERIC i386 >Description: I'm not sure if this could be a real problem, but there is a small typo in a KASSERT: in geom/geom_subr.c, function g_destroy_provider(), pp->acw is checked twice but pp->ace is not checked. >How-To-Repeat: >Fix: Index: geom/geom_subr.c =================================================================== RCS file: /home/ncvs/src/sys/geom/geom_subr.c,v retrieving revision 1.91 diff -b -u -p -r1.91 geom_subr.c --- geom/geom_subr.c 5 May 2007 16:33:44 -0000 1.91 +++ geom/geom_subr.c 4 Oct 2007 09:14:13 -0000 @@ -554,7 +554,7 @@ g_destroy_provider(struct g_provider *pp ("g_destroy_provider but attached")); KASSERT (pp->acr == 0, ("g_destroy_provider with acr")); KASSERT (pp->acw == 0, ("g_destroy_provider with acw")); - KASSERT (pp->acw == 0, ("g_destroy_provider with ace")); + KASSERT (pp->ace == 0, ("g_destroy_provider with ace")); g_cancel_event(pp); LIST_REMOVE(pp, provider); gp = pp->geom; >Release-Note: >Audit-Trail: >Unformatted: