From owner-freebsd-current@FreeBSD.ORG Thu Dec 4 16:00:26 2008 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 941F8106564A for ; Thu, 4 Dec 2008 16:00:26 +0000 (UTC) (envelope-from onemda@gmail.com) Received: from rn-out-0910.google.com (rn-out-0910.google.com [64.233.170.188]) by mx1.freebsd.org (Postfix) with ESMTP id 46C158FC08 for ; Thu, 4 Dec 2008 16:00:26 +0000 (UTC) (envelope-from onemda@gmail.com) Received: by rn-out-0910.google.com with SMTP id j71so3746049rne.12 for ; Thu, 04 Dec 2008 08:00:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:cc:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references; bh=sgSk3Xi5ln/C/jSkFxlkr+vyILOcYHGWvp0ZCc+WhMQ=; b=ROT0m0O5P2OjrmSF5zsL73EYLRg+xhMfdnxTxkAfWHykUPalTVqL+m70LiknZoOYVe w9+yw5L9yo4/1G+2V/6wzVLoFjmoVlc7ySoEhp+AMjLf/PCmPl/xuLwO15k5A1akyPUB tU2a3auFrHxSZmZu24gHqSJQ5+bQoUP3cO0z0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=VV5EdONTOEHbB8l9MOsXW0aQQ6AXkr/DziB9QEARiaSe1Z7XsFvnYrAuaHBtv8n3QH 9+qzGhBR8zKlmjtm4EwWnQQSi5pfaufb0QBXS+w/qCYIjP+/fTrpu/cudZfg/++33d5u l35dlzRDdjqff/YN5ch2AYGy08OUMij4LQhOc= Received: by 10.231.19.72 with SMTP id z8mr337667iba.42.1228406425134; Thu, 04 Dec 2008 08:00:25 -0800 (PST) Received: by 10.231.13.138 with HTTP; Thu, 4 Dec 2008 08:00:25 -0800 (PST) Message-ID: <3a142e750812040800h5bfa55fcsf52675c425183f8a@mail.gmail.com> Date: Thu, 4 Dec 2008 17:00:25 +0100 From: "Paul B. Mahol" To: "Maksim Yevmenkin" In-Reply-To: <3a142e750812040734g26ecda23pfe646c27521cdc82@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <7d6fde3d0812040324y3bf0901cy1f4a6d961362c314@mail.gmail.com> <3a142e750812040734g26ecda23pfe646c27521cdc82@mail.gmail.com> Cc: current@freebsd.org Subject: Re: RFC: small syscons and kbd patch X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Dec 2008 16:00:26 -0000 On 12/4/08, Paul B. Mahol wrote: > On 12/4/08, Maksim Yevmenkin wrote: >> On Thu, Dec 4, 2008 at 3:24 AM, Garrett Cooper wrote: >>> On Tue, Dec 2, 2008 at 5:01 PM, Maksim Yevmenkin >>> wrote: >>>> Dear Hackers, >>>> >>>> can someone please review the attached small patch for syscons and >>>> kbd? it should be a no-op mostly. the patch basically does >>>> >>>> 1) removes bogus layering in syscons, i.e. basically removes >>>> sccngetch(); >>>> 2) implements advisory lock for kbd (based on atomic(9)); >>>> 3) implements new POLLED flag for kbd; >>>> >>>> this is a part of a plan to fix keyboard access races in syscons. >>>> >>>> thanks, >>>> max >>> >>> Max, >>> Why are you double and triple negating on this line? >>> >>> + return (atomic_cmpset_acq_int(&kbd->kb_locked, !!!on, !!on)); >> >> the idea was to ensure that kbd->kb_locked variable only takes values >> 0 (zero) and 1 (one). >> >> thanks, >> max >> _______________________________________________ >> freebsd-current@freebsd.org mailing list >> http://lists.freebsd.org/mailman/listinfo/freebsd-current >> To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org" >> > > Maybe it is usefull to report, maybe not. > > I'm experiencing keyboard (atkbd) death now and then when inside Xorg once > Xorg is started in following (racey) way: > > alias onlyx "/usr/local/bin/xinit -- -nolisten tcp -br & && > exit" > > and /etc/csh.logout: > > echo $TERM | grep cons25 >> /dev/null && clear && vidcontrol -C > > I will test it and report if it fix my "problem". No luck. Typing blindly I managed to panic from kdb, and I got only this: KDB: enter: manual escape to debugger panic: from debugger cpuid = 1 KDB: stack backtrace: panic: bufwrite: buffer is not busy??? cpuid = 1 KDB: enter: panic exclusive sleep mutex Giant (Giant) r = 1 (0xc0725a70) locked @ /usr/src/sys/dev /syscons/syscons.c:618 -- Paul