From owner-cvs-src@FreeBSD.ORG Sat Aug 12 19:19:19 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 685DA16A4DA; Sat, 12 Aug 2006 19:19:19 +0000 (UTC) (envelope-from sam@errno.com) Received: from ebb.errno.com (ebb.errno.com [69.12.149.25]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3DEA843D5E; Sat, 12 Aug 2006 19:19:10 +0000 (GMT) (envelope-from sam@errno.com) Received: from [10.0.0.248] (trouble.errno.com [10.0.0.248]) (authenticated bits=0) by ebb.errno.com (8.13.6/8.12.6) with ESMTP id k7CJJ83A096102 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 12 Aug 2006 12:19:09 -0700 (PDT) (envelope-from sam@errno.com) Message-ID: <44DE29AC.3000409@errno.com> Date: Sat, 12 Aug 2006 12:19:08 -0700 From: Sam Leffler User-Agent: Thunderbird 1.5.0.4 (X11/20060724) MIME-Version: 1.0 To: Yar Tikhiy References: <200607090610.k696AO6E061602@repoman.freebsd.org> <20060812182543.GA39872@freefall.freebsd.org> In-Reply-To: <20060812182543.GA39872@freefall.freebsd.org> X-Enigmail-Version: 0.94.0.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sbin/ifconfig ifclone.c ifconfig.c ifconfig.h ifvlan.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Aug 2006 19:19:19 -0000 Yar Tikhiy wrote: > On Sun, Jul 09, 2006 at 06:10:24AM +0000, Sam Leffler wrote: >> sam 2006-07-09 06:10:23 UTC >> >> FreeBSD src repository >> >> Modified files: >> sbin/ifconfig ifclone.c ifconfig.c ifconfig.h ifvlan.c >> Log: >> o replace special handling of clone operations by a clone callback >> mechanism >> o change vlan cloning to use callback and pass all vlan parameters >> on create using the new SIOCREATE2 ioctl >> o update vlan set logic to match existing practice >> >> Revision Changes Path >> 1.2 +35 -21 src/sbin/ifconfig/ifclone.c >> 1.120 +12 -23 src/sbin/ifconfig/ifconfig.c >> 1.18 +2 -2 src/sbin/ifconfig/ifconfig.h >> 1.12 +78 -54 src/sbin/ifconfig/ifvlan.c > > Excuse me for noticing this late, but this change broke command > lines that had used to work, e.g: > > # ifconfig vlan77 create vlan 77 vlandev xl0 mtu 1006 up > ifconfig: ioctl (set mtu): Device not configured > ifconfig: ioctl (SIOCGIFFLAGS): no such interface > > My experience summarized in ifvlan.c rev. 1.11 showed that using > callbacks in ifconfig could be tricky because the order of processing > command-line parameters was important in some common cases. > I tested this; not sure what happened. I'm about to leave on holiday. If you don't want to work on it I'll look at it when I return in Sept. Sam