From owner-cvs-all Wed Jan 27 21:46:06 1999 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id VAA16814 for cvs-all-outgoing; Wed, 27 Jan 1999 21:46:06 -0800 (PST) (envelope-from owner-cvs-all@FreeBSD.ORG) Received: from ns.mt.sri.com (sri-gw.MT.net [206.127.105.141]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id VAA16804; Wed, 27 Jan 1999 21:46:04 -0800 (PST) (envelope-from nate@mt.sri.com) Received: from mt.sri.com (rocky.mt.sri.com [206.127.76.100]) by ns.mt.sri.com (8.8.8/8.8.8) with SMTP id WAA10764; Wed, 27 Jan 1999 22:46:03 -0700 (MST) (envelope-from nate@rocky.mt.sri.com) Received: by mt.sri.com (SMI-8.6/SMI-SVR4) id WAA26358; Wed, 27 Jan 1999 22:46:02 -0700 Date: Wed, 27 Jan 1999 22:46:02 -0700 Message-Id: <199901280546.WAA26358@mt.sri.com> From: Nate Williams MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit To: "Justin T. Gibbs" Cc: Matt Dillon , cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/i386/eisa ahb.c In-Reply-To: <199901280332.UAA25969@pluto.plutotech.com> References: <199901280133.RAA40079@freefall.freebsd.org> <199901280332.UAA25969@pluto.plutotech.com> X-Mailer: VM 6.34 under 19.16 "Lille" XEmacs Lucid Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk Justin T. Gibbs writes: > >dillon 1999/01/27 17:33:03 PST > > > > Modified files: > > sys/i386/eisa ahb.c > > Log: > > Fix parenthesization, but the code still looks wrong. > > > > Revision Changes Path > > 1.5 +7 -2 src/sys/i386/eisa/ahb.c > > There certainly was a bug there, but your commit made the driver > non-functional. Why not pass your concern on to the author/maintainer of > the driver instead of committing something that does not address the > problem? If I had missed your checkin mail, I would never have noticed the > bug especially after you cleared the compiler warning without really fixing > the problem. Justin's response is *exactly* the kind of thing that striving for -Wall buys us. We're fixing the warning, but not the problem. And yes, this happens alot in real software when zealots (no offense Matt) think that somehow -Wall will fix all your bugs. Yes, it is a goal to be strived for, and yes Matt has found a number of warnings (that although were harmless in practice) were potentially bad. But, making it a 'goal' is a bit much, especially when it's done with very little feedback other than 'this looks bad, should I fix it' followed in about 45 minutes by the commit message. If the author isn't paying attention or is offline, the '-Wall' fix goes in, whether it's correct or not. Nate To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message