From nobody Tue Jan 6 02:23:12 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dlZhc67HPz6Mx2P for ; Tue, 06 Jan 2026 02:23:12 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dlZhc54nsz3Fdn for ; Tue, 06 Jan 2026 02:23:12 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1767666192; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=rf87Tx7oDMKVKp3Q2aVgblQL72bDLHlJsJWdu1pKRO8=; b=r+RX5cmjXJwKF4U+ysrzBfil2eGFyaNJwTGugDxzre1VzbtlXyeZUqSRbz1cE47LsjtR/a id8rYVh/w0eoxBhdPmew+sqH/pGMSYHkAKegXQYgVgTJXWv4+4PjjQfT4/0OCGLETvrs6M EcOHoHlJsreOw72x9RBi10u+cx+RoQjTtqcHDWg6W6OKf6o0BoS9hutwbZgqej+q2wFZj0 OhbbK/mSJVoyuEghqLjghSMoE3FNcXoUqlY4+d4i8vE0Dm7IqgoUnm++8IxOtRu/Epx3jJ epLinZyXvOjyRWUNBCMM6ubgSVcFHNUn42YEmP9VGwZlY8V3ZFDWWwoApZ6qYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1767666192; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=rf87Tx7oDMKVKp3Q2aVgblQL72bDLHlJsJWdu1pKRO8=; b=hKOyvqZiqysqXHy6jLRKxslGxdFhsCvzFXtriqDS6CSG28KuU71wGFJO/6kEdQpGbqYz2z XYy1cZYtIccDMYQOOOgdB4fqDYKdSzQAxplCuH/ssNgxd2dc6ETuehYcpS8+lnYt/G8Wv/ YECygFAXrmWOHuZ6XJyGyKuL4isUhOx8702+4CcvCgfZt4CndsFrLgiU0olpnsVsFdOaot lF01r1mMpJCuBBn+UhFzEimWXgokQ3jh39LlNOAp6arnLS42VhykW2VZ5yFxUpD03DRltr NbHQuPd71v8QYdLkk4XtvoR+2iWBwa7cjJu5yD2UgNnOV3yqH+RWM7mnujsHEA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1767666192; a=rsa-sha256; cv=none; b=oUzrpwDtP0KXBEccQFi3cexzDuVfHEcNwpgJvYaw0X6dNa6dkugao1O8Zo9uDSbRW/LI9O HgZ50RcLi1xgHpYcHf6JO0VKnMrXEbROANJ8mLwl6PP3stlKEL+tI6vKcvPDkcz5poN8dg SpERRsHRZZ1w9T3z9OdQUHq6XL/9fTU+0qNOI5jPAHxnCtFkW3XagTC/BNFzHtToeuZ+k4 JtIizheCj6sK1X/9PeFaW8L2kS+pIVTRE2clIW9WkDuJRDzn/F5t8tixz2/TZ62rXgFX8v S57GB5d/hBBbXynhT+rVPhtHSQrjmUNyBa+6x+3uvD5HIvmVLo6qFUF4oYwZTg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4dlZhc4RmjznTx for ; Tue, 06 Jan 2026 02:23:12 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 44db0 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 06 Jan 2026 02:23:12 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Ahmad Khalifa Subject: git: 9b2478f60bfd - main - ng_tty: avoid the sign extention of char List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: vexeduxr X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 9b2478f60bfda663c84b48e272a2293159e1b0a0 Auto-Submitted: auto-generated Date: Tue, 06 Jan 2026 02:23:12 +0000 Message-Id: <695c7210.44db0.1fed2d7b@gitrepo.freebsd.org> The branch main has been updated by vexeduxr: URL: https://cgit.FreeBSD.org/src/commit/?id=9b2478f60bfda663c84b48e272a2293159e1b0a0 commit 9b2478f60bfda663c84b48e272a2293159e1b0a0 Author: Ahmad Khalifa AuthorDate: 2026-01-06 02:07:29 +0000 Commit: Ahmad Khalifa CommitDate: 2026-01-06 02:10:11 +0000 ng_tty: avoid the sign extention of char When c is compared to sc->hotchar, both undergo integer promotion, which can lead to c being sign extended. Fix this by casting c to an unsigned char. Reviewed by: kevans MFC after: 5 days Differential Revision: https://reviews.freebsd.org/D54544 --- sys/netgraph/ng_tty.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sys/netgraph/ng_tty.c b/sys/netgraph/ng_tty.c index 0e3230a66f66..200a72336110 100644 --- a/sys/netgraph/ng_tty.c +++ b/sys/netgraph/ng_tty.c @@ -489,7 +489,8 @@ ngt_rint(struct tty *tp, char c, int flags) m->m_pkthdr.len++; /* Ship off mbuf if it's time */ - if (sc->hotchar == -1 || c == sc->hotchar || m->m_len >= MHLEN) { + if (sc->hotchar == -1 || (u_char)c == sc->hotchar || + m->m_len >= MHLEN) { sc->m = NULL; NG_SEND_DATA_ONLY(error, sc->hook, m); /* Will queue */ }