From owner-freebsd-perl@FreeBSD.ORG  Tue Mar 25 18:45:32 2014
Return-Path: <owner-freebsd-perl@FreeBSD.ORG>
Delivered-To: perl@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 5C90A864;
 Tue, 25 Mar 2014 18:45:32 +0000 (UTC)
Received: from winston.madpilot.net (winston.madpilot.net [78.47.75.155])
 by mx1.freebsd.org (Postfix) with ESMTP id 16FBB3E8;
 Tue, 25 Mar 2014 18:45:31 +0000 (UTC)
Received: from winston.madpilot.net (localhost [127.0.0.1])
 by winston.madpilot.net (Postfix) with ESMTP id 3fthGy6lkmzFTB5;
 Tue, 25 Mar 2014 19:45:30 +0100 (CET)
Received: from winston.madpilot.net ([127.0.0.1])
 by winston.madpilot.net (winston.madpilot.net [127.0.0.1]) (amavisd-new,
 port 10024)
 with ESMTP id 7bFKtY8eaPcm; Tue, 25 Mar 2014 19:45:28 +0100 (CET)
Received: from marvin.madpilot.net (micro.madpilot.net [88.149.173.206])
 by winston.madpilot.net (Postfix) with ESMTPSA;
 Tue, 25 Mar 2014 19:45:28 +0100 (CET)
Message-ID: <5331CEC8.9040504@FreeBSD.org>
Date: Tue, 25 Mar 2014 19:45:28 +0100
From: Guido Falsi <madpilot@FreeBSD.org>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
 rv:24.0) Gecko/20100101 Thunderbird/24.4.0
MIME-Version: 1.0
To: Tijl Coosemans <tijl@FreeBSD.org>, mat@FreeBSD.org, perl@FreeBSD.org
Subject: Re: svn commit: r349107 - in head/converters/p5-Text-Iconv: . files
References: <201403250723.s2P7N6cc052424@svn.freebsd.org>
 <20140325154013.06cfd18a@kalimero.tijl.coosemans.org>
In-Reply-To: <20140325154013.06cfd18a@kalimero.tijl.coosemans.org>
X-Enigmail-Version: 1.6
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-BeenThere: freebsd-perl@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: maintainer of a number of perl-related ports
 <freebsd-perl.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-perl>,
 <mailto:freebsd-perl-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-perl/>
List-Post: <mailto:freebsd-perl@freebsd.org>
List-Help: <mailto:freebsd-perl-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-perl>,
 <mailto:freebsd-perl-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 25 Mar 2014 18:45:32 -0000

On 03/25/14 15:40, Tijl Coosemans wrote:
> Thanks, I received a PR about this yesterday:
> http://www.freebsd.org/cgi/query-pr.cgi?pr=187907
> 
> The OSVERSION check isn't correct though.  It should be empty(ICONV_LIB).
> But, I've attached a patch that uses a different approach.  You can
> make the port use /usr/include/iconv.h by replacing LOCALBASE in
> CONFIGURE_ARGS with ICONV_PREFIX.
> 
> That fixes the build phase, during configure however, something(?) is
> still adding -I/usr/local/include to the command line so you still need
> -DLIBICONV_PLUG when empty(ICONV_LIB).  The patch adds CFLAGS to INC in
> CONFIGURE_ARGS for this.  You can verify this by adding verbose=1 to
> CONFIGURE_ARGS and running "make configure".
> 
> Can perl@ review/approve this?

I did not think about stuffing CFLAGS in INC, good catch! :)

I did not see that PR, I would have filed my patch as followup if I had.

-- 
Guido Falsi <madpilot@FreeBSD.org>