From owner-svn-src-all@freebsd.org Tue Jul 26 16:27:08 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C5198BA49C2 for ; Tue, 26 Jul 2016 16:27:08 +0000 (UTC) (envelope-from ed@nuxi.nl) Received: from mail-yw0-x22c.google.com (mail-yw0-x22c.google.com [IPv6:2607:f8b0:4002:c05::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8DD2E1358 for ; Tue, 26 Jul 2016 16:27:08 +0000 (UTC) (envelope-from ed@nuxi.nl) Received: by mail-yw0-x22c.google.com with SMTP id r9so20620735ywg.0 for ; Tue, 26 Jul 2016 09:27:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuxi-nl.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=b9mGP9yGdTjyyI2p6Ra7fz6LSu6YuLmZFDQsOyNG1PI=; b=jGO5IUlSpsVX2o2qFz2oWb+Ynsq4jTnyVREKrfBM1W44Kg2LVNm8TyuA9Yw/cY9Da8 IiGnMwQAkwl5EE0nYkbIJL6OnnWzzSfnOEvLvtecpW+PUQrJnXrQKLm/G+ErxA8+AsRe zDbln9kuNIOr3/7w1pFDLkxKJWw5nG103R7Cgd0xCJGtBa3CxwUO08f1x3ypCDm8kffm 2YFhUHctul6eUxTPOTHUxo8jD9p2uyL8VTmCJiRuT8rfmFNpV2Zbb+T/As68DwhrheC2 +EwxmFKRLPSZRVuhGHJfmFm9NlA9QJ0TxK+UprYPAEhp4xtdh/WKNcygaUffk3YWdhQC hPlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=b9mGP9yGdTjyyI2p6Ra7fz6LSu6YuLmZFDQsOyNG1PI=; b=Yijvp+8jotuBmoltqve0IqL+TGKB2JcRZw6EkwMIzrl9SjjyBEjdaXlmCfGc3napOV EYBwuHW+zJnuf9Ir/yPmw90Nn/Et5/Fn+fCyiilWqR8B1TSPifWoAIKsqrpyzpfVO0Be /EcaauBnB4D/U9iJoiJRj8mAH7OLUweEk7X9TAzzGbsnCvjKGAXbIQd0X5nIPzFfL3Kk 3yh+07cClT8+xfzCCNPntQLAff8WZNLDduzfBqo1X0cmJILO298Fv0FT360wUKdpfyP6 ShI7HcsdNmxsHLT+bKzKE0p7aA1ccd37o6pECZHMQ70tjxHV/Dc96RKR2RT7gGFbApIT w+1g== X-Gm-Message-State: AEkoousQbEJL7Cz3zR1dSM5NoZEzuhYhx68c5xu4h1uIl39Ms5gJT9E/UizKBPH9ZbqU/1n7XAMykJsfFbyCKw== X-Received: by 10.129.90.7 with SMTP id o7mr20971687ywb.313.1469550427634; Tue, 26 Jul 2016 09:27:07 -0700 (PDT) MIME-Version: 1.0 Received: by 10.13.201.71 with HTTP; Tue, 26 Jul 2016 09:27:07 -0700 (PDT) In-Reply-To: <201607261534.u6QFYQ9L017045@repo.freebsd.org> References: <201607261534.u6QFYQ9L017045@repo.freebsd.org> From: Ed Schouten Date: Tue, 26 Jul 2016 18:27:07 +0200 Message-ID: Subject: Re: svn commit: r303338 - head/sys/dev/vt To: Ed Maste Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Jul 2016 16:27:08 -0000 Hi Ed, 2016-07-26 17:34 GMT+02:00 Ed Maste : > if (vw == vd->vd_curwindow) { > + mtx_lock(&Giant); > kbd = kbd_get_keyboard(vd->vd_keyboard); > if (kbd != NULL) > vt_save_kbd_state(vw, kbd); > + mtx_unlock(&Giant); > } Would it make sense to put an mtx_assert(&Giant, MA_OWNED) in kbd_get_keyboard()? -- Ed Schouten Nuxi, 's-Hertogenbosch, the Netherlands KvK-nr.: 62051717