Date: Sun, 1 Apr 2012 13:51:07 -0400 From: Eitan Adler <lists@eitanadler.com> To: Ruslan Mahmatkhanov <cvs-src@yandex.ru> Cc: FreeBSD Ports Mailing List <ports@freebsd.org> Subject: Re: Preferred way of applying OSVERSION-dependend patches Message-ID: <CAF6rxg=BU4NzRrcAQGJfZTJXLN0550mgscPaFq1pq=FjSO6bkA@mail.gmail.com> In-Reply-To: <4F7827A7.3030804@yandex.ru> References: <4F7827A7.3030804@yandex.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
On 1 April 2012 06:02, Ruslan Mahmatkhanov <cvs-src@yandex.ru> wrote:
>
> Good day!
>
> What is a preferred way of doing subj?
>
> 1. Add an extra-patch-* to files/ subdirectory and apply it depending
> =C2=A0 of checks in Makefile (.if ${OSVERSION}).
> 2. Add an patch-* to files subdirectory that applies unconditionally
> =C2=A0 and that checking for __FreeBSD_version in app code itself.
>
> The second one will guarantee that the patch still applies cleanly on por=
t
> versions update, but it will make it more hard to find conditional checks
> for obsoleted FreeBSD versions (because most people, I believe, only look=
ing
> to Makefile for things like this).
#1 for exactly the reason you specify: it makes it easier to figure
out why something is being patched and when that patch is no longer
required.
--=20
Eitan Adler
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAF6rxg=BU4NzRrcAQGJfZTJXLN0550mgscPaFq1pq=FjSO6bkA>