From owner-svn-src-head@freebsd.org Wed Nov 15 21:23:33 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 09114DE7AE4 for ; Wed, 15 Nov 2017 21:23:33 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-io0-x231.google.com (mail-io0-x231.google.com [IPv6:2607:f8b0:4001:c06::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id BAE3E7C7E1 for ; Wed, 15 Nov 2017 21:23:32 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-io0-x231.google.com with SMTP id q101so3072142ioi.1 for ; Wed, 15 Nov 2017 13:23:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=6Q5Tg0hhyq82WQ+H9Q6MGb4rzyrvvNAmMNVrjNyHIr0=; b=XSHnf+jUaSFHPfPTL1ZAsm2ZaMCRtJ7DtWuLwpS7DZXAmWvv5BLv8SLRao1MtNohkT lM7/ifmLuALsvftsg8np94iWxpHCt6bAvGUBuvEqQoKe9xx3mWx4xrrMuK79UD3WS0t7 dlhqKB1PrIBgsnmjUZns9fWTPbdFc7rfT2ET29jQ7QaVDHpfGkyCiWKaZYsvJyvK3HSa /kshCGpYm+jRUSpT6D1XzV2sxHGu86DKcXhiramb6MQEKFLeDIxSEB0XsX+ijhbH7xbC NHVsbCHFr9YRsqq+RqD8ObLRS1D2rwFeVgrhWjjwM1ZmokskzIYCNcOAHz9IA+RQTStz 8ZDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=6Q5Tg0hhyq82WQ+H9Q6MGb4rzyrvvNAmMNVrjNyHIr0=; b=DmwHum3gpsz4nlbEDjeZbvuGk9p9QmlydMoS1wDeCuCrdCI5TCLbcxIPSraFnj5qT7 sK0oarhSc0mjU6bHkAhXMqqG0HLT757ChwTW47rd6/2qNltTxfH/+IRMm+qOBIM89QsE 6r3GT0RIGAJwCFRDP6lOhwG39FmOhtUJjcWVbd9OHYwVAqzRlQgqwyp2C47WtRQ6n65W +mo+cLNLtAzR5cTC09rtWkOiQMzgEhFfwz2sx2Rq1gAy7Cho9NHRRqhx6prtwAC0hpBy 3CTaT56TJPeZktyeSt6DsyyG99rdieV4nvlvdhAa1ZU+ORH8/xo2jYHpZHf2DJ7/MAN3 1RMA== X-Gm-Message-State: AJaThX6yUg05pwyxXbwB6OhRSQ6rHjzJA3DUSvQRlUlDg0mY761iO9fe LhSJ97mvpcNjZJv5WX9K8cKvAtzjEAybcFkWQ3IvPA== X-Google-Smtp-Source: AGs4zMbzbNfSS3EJGLNtu7bnkJelC4OQNyT9UKuQLbesTKK9226+K0AeyobpizEetYMuVv4jN1Mt7v98vhjjZ7KQDzY= X-Received: by 10.107.48.195 with SMTP id w186mr5977338iow.301.1510781011872; Wed, 15 Nov 2017 13:23:31 -0800 (PST) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.108.204 with HTTP; Wed, 15 Nov 2017 13:23:30 -0800 (PST) X-Originating-IP: [2607:fb90:6cbb:3482:ed95:2e8b:8936:7768] Received: by 10.79.108.204 with HTTP; Wed, 15 Nov 2017 13:23:30 -0800 (PST) In-Reply-To: <201711152113.vAFLDcSJ053119@pdx.rh.CN85.dnsmgr.net> References: <201711152113.vAFLDcSJ053119@pdx.rh.CN85.dnsmgr.net> From: Warner Losh Date: Wed, 15 Nov 2017 14:23:30 -0700 X-Google-Sender-Auth: suaXxrpuqLV2zcu4h4C0et8sQgw Message-ID: Subject: Re: svn commit: r325860 - head/sbin/newfs To: "Rodney W. Grimes" Cc: Ed Maste , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Nov 2017 21:23:33 -0000 On Nov 15, 2017 2:13 PM, "Rodney W. Grimes" wrote: [ Charset UTF-8 unsupported, converting... ] > On Nov 15, 2017 1:51 PM, "Rodney W. Grimes" > wrote: > > [ Charset UTF-8 unsupported, converting... ] > > On Nov 15, 2017 11:47 AM, "Rodney W. Grimes" net> > > wrote: > > > > > Author: emaste > > > Date: Wed Nov 15 18:40:40 2017 > > > New Revision: 325860 > > > URL: https://svnweb.freebsd.org/changeset/base/325860 > > > > > > Log: > > > newfs: warn if newer than kernel > > > > > > Creating a UFS filesystem with a newfs newer than the running kernel, > > > and then mounting that filesystem, can lead to interesting failures. > > > > > > Add a safety belt to explicitly warn when newfs is newer than the > > > running kernel. > > > > You should probably make the warning if (newer || older) as > > either is likely to have interesting side effects, as are > > mounting ufs file systems on different versions. > > > > > > Not really. The cg stuff is really only a hassle for the case ed is > testing > > for. > > Its too late now, but if you take a newer ufs with the cg > stuff in them and mount it on an old system it politly well > corrupt the data that the newer kernel needs. So your right, > doing this check in newfs wont do anything, but I can tell > you this tiny little chain has been a PITA for people that > move HD around.... > > > Fsck automatically fixes issues like that. It recomputes the checksums. Yes, but you do not know that this is needed until AFTER you have mounted the "Clean" file system and started using it, and then you get some nasty messages (though they are a little better now than the original ones). So then you have to manually fire off a fsck on the volume... It's just a minor annoyance.... no data is lost. > > > *Sigh* why did not UFS grow a version number of its own > > when things started to change other than UFS1 vs UFS2. > > > > > > This isn't anything like those changes.. > > UFS changed in a way that makes it difficult to move > UFS drives accross systems that are at differing versions. > That IS bad no mater how you slice it. I now have to make > sure I fsck a drive when moving it from an old to new > system to get the cg checksum stuff fixed. > > > Except it isn't as bad as you say. It is a distracting PITA, you probably dont move a UFS formatted flash drive around between as many differing systems as I do. I've been dealing with false positives for these messages at work... Oh, and can you please get a mail client that does proper quoting? It's just gmail. And there's really no alternative :( Warner > Rod Grimes > rgrimes@freebsd.org -- Rod Grimes rgrimes@freebsd.org