From owner-svn-src-all@FreeBSD.ORG Thu Oct 22 07:07:21 2009 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0BD1E1065672; Thu, 22 Oct 2009 07:07:21 +0000 (UTC) (envelope-from rdivacky@vlk.vlakno.cz) Received: from vlakno.cz (77-93-215-190.static.masterinter.net [77.93.215.190]) by mx1.freebsd.org (Postfix) with ESMTP id B77058FC17; Thu, 22 Oct 2009 07:07:20 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by vlakno.cz (Postfix) with ESMTP id ADD979CB29E; Thu, 22 Oct 2009 09:06:40 +0200 (CEST) X-Virus-Scanned: amavisd-new at vlakno.cz Received: from vlakno.cz ([127.0.0.1]) by localhost (lev.vlakno.cz [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id M5-NisHRc9nv; Thu, 22 Oct 2009 09:06:38 +0200 (CEST) Received: from vlk.vlakno.cz (localhost [127.0.0.1]) by vlakno.cz (Postfix) with ESMTP id 57C829CB43E; Thu, 22 Oct 2009 09:06:38 +0200 (CEST) Received: (from rdivacky@localhost) by vlk.vlakno.cz (8.14.3/8.14.3/Submit) id n9M76c9b099013; Thu, 22 Oct 2009 09:06:38 +0200 (CEST) (envelope-from rdivacky) Date: Thu, 22 Oct 2009 09:06:38 +0200 From: Roman Divacky To: Ruslan Ermilov Message-ID: <20091022070638.GA97875@freebsd.org> References: <200910211707.n9LH7kHx005204@svn.freebsd.org> <20091021210707.GB5410@edoofus.dev.vega.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20091021210707.GB5410@edoofus.dev.vega.ru> User-Agent: Mutt/1.4.2.3i Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r198335 - head/share/mk X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Oct 2009 07:07:21 -0000 On Thu, Oct 22, 2009 at 01:07:07AM +0400, Ruslan Ermilov wrote: > On Wed, Oct 21, 2009 at 05:07:46PM +0000, Roman Divacky wrote: > > Author: rdivacky > > Date: Wed Oct 21 17:07:46 2009 > > New Revision: 198335 > > URL: http://svn.freebsd.org/changeset/base/198335 > > > > Log: > > Set CSTD in all cases except when CC=icc and NO_WARNS is set. This > > way we can set desired C standard even for cross tools etc. > > > I think you meant to say "always set CFLAGS based on CSTD". > Unfortunately the actual change does not only that, it also > breaks NO_WARNS (by ignoring it) for anything that's not "icc". yes, it sets the C standard regardless of NO_WARNS > It also breaks "icc" compiles without NO_WARNS by passing > unrecognized flags to the compiler. A correct change would > be to move setting of CFLAGS based on CSTD out of the control > of NO_WARNS, like this: previously it did: NO_WARNS ICC CFLAGS includes CSTD 0 0 1 0 1 0 1 0 0 1 1 0 now it does NO_WARNS ICC CFLAGS includes CSTD 0 0 1 0 1 1 1 0 1 1 1 0 so you are saying that for ICC and !NO_WARNS the CFLAGS should not include CSTD? ie: NO_WARNS ICC CFLAGS includes CSTD 0 0 1 0 1 0 1 0 1 1 1 0 am I right? my intention was to set the C standard regardless of NO_WARNS for "clang" (because it default to C99 and gcc breaks with it). feel free to fix my commit if this is the case thank you