From owner-freebsd-arch@FreeBSD.ORG  Sun Jun 22 01:50:24 2003
Return-Path: <owner-freebsd-arch@FreeBSD.ORG>
Delivered-To: freebsd-arch@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 3252137B401
	for <arch@freebsd.org>; Sun, 22 Jun 2003 01:50:24 -0700 (PDT)
Received: from HAL9000.homeunix.com (ip114.bella-vista.sfo.interquest.net
	[66.199.86.114])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 8C1D143FA3
	for <arch@freebsd.org>; Sun, 22 Jun 2003 01:50:23 -0700 (PDT)
	(envelope-from dschultz@OCF.Berkeley.EDU)
Received: from HAL9000.homeunix.com (localhost [127.0.0.1])
	by HAL9000.homeunix.com (8.12.9/8.12.9) with ESMTP id h5M8oKJa062066;
	Sun, 22 Jun 2003 01:50:20 -0700 (PDT)
	(envelope-from dschultz@OCF.Berkeley.EDU)
Received: (from das@localhost)
	by HAL9000.homeunix.com (8.12.9/8.12.9/Submit) id h5M8oKiJ062065;
	Sun, 22 Jun 2003 01:50:20 -0700 (PDT)
	(envelope-from dschultz@OCF.Berkeley.EDU)
Date: Sun, 22 Jun 2003 01:50:20 -0700
From: David Schultz <dschultz@OCF.Berkeley.EDU>
To: Bruce Evans <bde@zeta.org.au>
Message-ID: <20030622085020.GA61926@HAL9000.homeunix.com>
Mail-Followup-To: Bruce Evans <bde@zeta.org.au>, arch@freebsd.org
References: <20030622005124.GA59673@HAL9000.homeunix.com>
	<20030622114150.L54976@gamplex.bde.org>
	<20030622035258.GB60460@HAL9000.homeunix.com>
	<20030622180851.K55800@gamplex.bde.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20030622180851.K55800@gamplex.bde.org>
cc: arch@freebsd.org
Subject: Re: Per-source CFLAGS
X-BeenThere: freebsd-arch@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussion related to FreeBSD architecture
	<freebsd-arch.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arch>
List-Post: <mailto:freebsd-arch@freebsd.org>
List-Help: <mailto:freebsd-arch-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 22 Jun 2003 08:50:24 -0000

On Sun, Jun 22, 2003, Bruce Evans wrote:
> On Sat, 21 Jun 2003, David Schultz wrote:
> > ???  You mean we can't add a variable that will normally expand to
> > nil?  This seems like a compatible change, unless you're worried
> > about someone's makefile breaking because they defined
> > CFLAGS_foo.c to mean something else.
> 
> >From POSIX.1-200x-draft7.txt:
> 
> % 23836                 Default Rules
> % 23837                 The default rules for make shall achieve results that are the same as if the following were used.
     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> % ...
> % 23864            SINGLE SUFFIX RULES
> % 23865            .c:
> % 23866                    $(CC) $(CFLAGS) $(LDFLAGS) -o $@ $<
> 
> This leaves little scope for modifying the default rules.

The results *are* the same with the added ${CFLAGS_$<}, with the
exception of the extra space in the argument list, and I don't
think that's what the POSIX people were thinking.  Is there a
specific problem that this patch would cause for people expecting
standards-compliant make magic (other than a name conflict)?

By the way, is your only complaint that I should not be making
this modification in sys.mk?  I'd be perfectly happy to remove
that part.  I really only care about bsd.lib.mk at the moment, and
the rest was a hasty afterthought for completeness' sake.
To do a complete job without touching sys.mk, it looks like I would
need to duplicate a number of default rules in bsd.prog.mk, though...