From owner-freebsd-office@freebsd.org Tue May 17 19:29:34 2016 Return-Path: Delivered-To: freebsd-office@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C7273B3EB8A for ; Tue, 17 May 2016 19:29:34 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id B29B21449 for ; Tue, 17 May 2016 19:29:34 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id B1EBDB3EB88; Tue, 17 May 2016 19:29:34 +0000 (UTC) Delivered-To: office@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B1926B3EB87 for ; Tue, 17 May 2016 19:29:34 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id A26B41448 for ; Tue, 17 May 2016 19:29:34 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id u4HJTYhM089954 for ; Tue, 17 May 2016 19:29:34 GMT (envelope-from bugzilla-noreply@freebsd.org) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" From: bugzilla-noreply@freebsd.org To: office@FreeBSD.org Subject: maintainer-feedback requested: [Bug 209588] editors/openoffice-4 editors/openoffice-devel: Fix build with libc++ 3.8.0 Date: Tue, 17 May 2016 19:29:34 +0000 X-Bugzilla-Type: request X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: office@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? Message-ID: In-Reply-To: References: X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-office@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Office applications on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 May 2016 19:29:34 -0000 Dimitry Andric has reassigned Bugzilla Automation 's request for maintainer-feedback to office@FreeBSD.= org: Bug 209588: editors/openoffice-4 editors/openoffice-devel: Fix build with libc++ 3.8.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D209588 --- Description --- Created attachment 170415 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D170415&action= =3Dedit Rename custom round() and use a define to minimize changes During the exp-run in bug 208158, it was found that editors/openoffice-4 [1] and editors/openoffice-devel [2] give errors with libc++ 3.8.0: /wrkdirs/usr/ports/editors/openoffice-4/work/aoo-4.1.2/main/vcl/source/glyp= hs/g raphite_layout.cxx:297:21: error: call to 'round' is ambiguous long nXOffset =3D round(fMinX * fScaling); ^~~~~ This is because openoffice defines its own overloaded variant of round(), w= hich is only different in return type from the 'real' round() from , so = it is ambiguous (in the C++ lookup sense). Fix this by renaming the custom round() to round_(), and using a define to minimize needed changes in the c= ode. [1] http://package18.nyi.freebsd.org/data/headamd64PR208158-default/2016-05-01_= 10h2 9m48s/logs/errors/apache-openoffice-4.1.2_5.log [2] http://package18.nyi.freebsd.org/data/headamd64PR208158-default/2016-05-01_= 10h2 9m48s/logs/errors/apache-openoffice-devel-4.2.1735889_1,4.log