From owner-svn-src-all@freebsd.org Mon Jun 15 15:47:29 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 73E9B338380 for ; Mon, 15 Jun 2020 15:47:29 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qk1-x735.google.com (mail-qk1-x735.google.com [IPv6:2607:f8b0:4864:20::735]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 49lwh04lS6z3YGj for ; Mon, 15 Jun 2020 15:47:28 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qk1-x735.google.com with SMTP id n141so16160538qke.2 for ; Mon, 15 Jun 2020 08:47:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ABduOYTC/N5j7pR3JNvQwlP5VjVV/9ibuIYv4jerhOc=; b=C8ja9Db69k1Bx9Qg9LnwiSiFMYKqXOxQyXV7s7pmqWU/RRVHCe3UR1Na4hmvljgknP WpZfQKjZXGx16L8z+mzEuUG34lvPd0wAOmbsLzQxH6VnWs7v6OW9Hz18GqNfw/oPZPAu D5ESJy5YKLG+DZmSAmdLEq/KmM80hNg3KYP8IQZ4OJ9JPCn9ykZ7JPK5Plgf4V+rsK5/ 7oZjubg6p3LihxCSyIEkagTVJMAkZTcVBF6E/rHjUFYM1xSt4AiR4hBCBUBaTszonfa4 u2rktuKLD0wmc4k6XBLtc2oUIMCujtW/zZxgPDwE6gjXYe2J2TqCgRFwCXYiMdQdnLt3 t6WQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ABduOYTC/N5j7pR3JNvQwlP5VjVV/9ibuIYv4jerhOc=; b=iI0wxdLItxQQTn/BFcjKR+EHR1f9Q7NuWcqEGmvx0lYKQUdPtqETJgXvPl17EsS+YR xAPHUs5blTOsGuO0RoFDP0JD2CBqIKJQ8AsYQ1qc5/C2N2VFEoKmubVSECm01OIhltoa d7BSLT+KNIwXS6gci28lNg0JZRQF2zMMx+R6LpOfbM1dQDEgbPTE7z47pnBW3wZR9lfO t55/f5b7XU4eSR9YrmBNz07ER+slz1ob76Nrom8AsIwPjOTPGiI671gKaBcaRKxeRGPb gq23/03Sg78nxWtmWPSuS5OZEqFplpNbizvJDURmlbUDa4eL4k29AX/2np31Lo8jhqpD 9X0w== X-Gm-Message-State: AOAM531H4BXH5DGKuBR2KtoX9TdvSlfqx3N7sfcjssOFWOjDbl84FBwz DLKCVSljm0o6G1eYrvLnOIJKwO/pTUOb8Mdjl7JJFA== X-Google-Smtp-Source: ABdhPJwjCRQ5yehuuJQesB4pNnibdVCienkrH9WKC7nABqqgUAK/8f82VdMRrO+nkRsJKeabuqdqUicDSGcwziFfsPA= X-Received: by 2002:a37:392:: with SMTP id 140mr15524006qkd.495.1592236047828; Mon, 15 Jun 2020 08:47:27 -0700 (PDT) MIME-Version: 1.0 References: <202006151233.05FCXN4L076562@gndrsh.dnsmgr.net> <146239e5-081f-18f7-3a3b-54d912fb8bfd@FreeBSD.org> In-Reply-To: <146239e5-081f-18f7-3a3b-54d912fb8bfd@FreeBSD.org> From: Warner Losh Date: Mon, 15 Jun 2020 09:47:16 -0600 Message-ID: Subject: Re: svn commit: r362191 - head/sbin/md5 To: Mateusz Piotrowski <0mp@freebsd.org> Cc: "Rodney W. Grimes" , =?UTF-8?Q?Fernando_Apestegu=C3=ADa?= , src-committers , svn-src-all , svn-src-head X-Rspamd-Queue-Id: 49lwh04lS6z3YGj X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20150623.gappssmtp.com header.s=20150623 header.b=C8ja9Db6; dmarc=none; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2607:f8b0:4864:20::735) smtp.mailfrom=wlosh@bsdimp.com X-Spamd-Result: default: False [-1.99 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.78)[-0.779]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com:s=20150623]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-0.48)[-0.479]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-src-all@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; RCPT_COUNT_FIVE(0.00)[6]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; NEURAL_HAM_SHORT(-0.73)[-0.732]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::735:from]; R_SPF_NA(0.00)[no SPF record]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.33 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Jun 2020 15:47:29 -0000 On Mon, Jun 15, 2020 at 7:34 AM Mateusz Piotrowski <0mp@freebsd.org> wrote: > Hi, > > On 6/15/20 2:33 PM, Rodney W. Grimes wrote: > > [ Charset UTF-8 unsupported, converting... ] > >> Author: fernape (ports committer) > >> Date: Mon Jun 15 10:08:02 2020 > >> New Revision: 362191 > >> URL: https://svnweb.freebsd.org/changeset/base/362191 > >> > >> Log: > >> md5(1): fix style in man page > > > > Mandoc is fine to ignore this, but it is wrong to call it useless. > > > > I really wish that this stop. .Tn might be useless to mandoc, > > but it is a very usable thing if your formatting to something > > other than txt, as in a ps or pdf. > > In that case I would consider patching our in-tree mandoc to not warn > about Tn. Or request support for Tn or a well-defined replacement upstream. > > I can see the benefit of keeping Tn around, as it /might/ potentially > create nice formatting for HTML. On the other hand, I don't like the > idea of not following the linter. > I thought that Tn thing was the general consensus thing and added to the linter because of that. The man page explains why it's problematic: Tn word ... Supported only for compatibility, do not use this in new manuals. Even though the macro name ("tradename") suggests a semantic function, historic usage is inconsistent, mostly using it as a presentation-level macro to request a small caps font. It was useful for the Unix trademark, but was tailor towards AT&T's preferred dressing for the Unix trademark, not for trademarks in general. In this case, there were several instances of abuse: -.Tn RSA . +key under a public-key cryptosystem such as RSA. Not a trademark in this context. RSA is a trademark for the RSA corporation and it uses it in various other contexts. -The -.Tn MD5 -and -.Tn SHA-1 -algorithms have been proven to be vulnerable to practical collision -attacks and should not be relied upon to produce unique outputs, +The MD5 and SHA-1 algorithms have been proven to be vulnerable to practical +collision attacks and should not be relied upon to produce unique outputs, MD5 and SHA-1 are not trade names in this context. The rest seem similar, though I've not gone to the trouble to look them all up. All in all, while I have some sympathy to Rod's view that we're losing semantic information by these changes in general, this particular one actually fixes the abuse talked about in the mdoc manual, IMHO. Warner