Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 19 Oct 2011 23:33:48 +0000 (UTC)
From:      Pawel Jakub Dawidek <pjd@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r226550 - head/sys/cddl/boot/zfs
Message-ID:  <201110192333.p9JNXmZ8047283@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: pjd
Date: Wed Oct 19 23:33:48 2011
New Revision: 226550
URL: http://svn.freebsd.org/changeset/base/226550

Log:
  Initialize 'rc' properly before using it. This error could lead to infinite
  loop when data reconstruction was needed.
  
  MFC after:	3 days

Modified:
  head/sys/cddl/boot/zfs/zfssubr.c

Modified: head/sys/cddl/boot/zfs/zfssubr.c
==============================================================================
--- head/sys/cddl/boot/zfs/zfssubr.c	Wed Oct 19 23:31:50 2011	(r226549)
+++ head/sys/cddl/boot/zfs/zfssubr.c	Wed Oct 19 23:33:48 2011	(r226550)
@@ -1628,7 +1628,9 @@ reconstruct:
 
 	n = 0;
 	for (c = 0; c < rm->rm_cols; c++) {
-		if (rm->rm_col[c].rc_tried)
+		rc = &rm->rm_col[c];
+
+		if (rc->rc_tried)
 			continue;
 
 		cvd = vdev_child(vd, rc->rc_devidx);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201110192333.p9JNXmZ8047283>