From owner-freebsd-current@FreeBSD.ORG  Thu Apr 14 01:45:26 2005
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 0467316A4D1
	for <current@FreeBSD.org>; Thu, 14 Apr 2005 01:45:26 +0000 (GMT)
Received: from sp.dominia.org (efnet-math.org [69.60.109.125])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 4E6F243D53
	for <current@FreeBSD.org>; Thu, 14 Apr 2005 01:45:25 +0000 (GMT)
	(envelope-from ssouhlal@FreeBSD.org)
Received: from [192.168.1.12] (63-170-138-118.cst-sg.blacksburg.ntc-com.net
	[63.170.138.118])	(authenticated bits=0)
	by sp.dominia.org (8.13.1/8.13.1) with ESMTP id j3E1jLRp011805
	(version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NO);
	Wed, 13 Apr 2005 21:45:22 -0400
In-Reply-To: <20050413054020.GL56487@funkthat.com>
References: <0842a01b5aa0cfcd84763fff4a30113e@FreeBSD.org>
	<20050413054020.GL56487@funkthat.com>
Mime-Version: 1.0 (Apple Message framework v619.2)
Content-Type: text/plain; charset=US-ASCII; format=flowed
Message-Id: <7924a1be6ee3f91af6ce6a6cc003edaa@FreeBSD.org>
Content-Transfer-Encoding: 7bit
From: Suleiman Souhlal <ssouhlal@FreeBSD.org>
Date: Wed, 13 Apr 2005 21:45:17 -0400
To: John-Mark Gurney <gurney_j@resnet.uoregon.edu>
X-Mailer: Apple Mail (2.619.2)
cc: current@FreeBSD.org
Subject: Re: [PATCH] Allow watching of vnodes that reside on non-UFS
	filesystems with kqueue
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 14 Apr 2005 01:45:26 -0000

Hello,

On Apr 13, 2005, at 1:40 AM, John-Mark Gurney wrote:

> I would prefer to move the vfs_kqfilter and filt_vfs* functions either
> be moved to a vfs specific file, or be moved to their own file..  also,
> it appears that we lost support for extending of files... though I 
> can't
> confirm that...  Have you verified that extending still gets notified?

The patch at 
http://people.freebsd.org/~ssouhlal/testing/kqueue-hooks-20050413.diff 
addresses the things you mentioned and introduces a MNTK_NOKNOTE flag 
to mount->mnt_kern_flag so that a filesystem can override the sending 
of knotes from the VOP hooks, in case it needs to do something 
filesystem-specific.

I will also send this patch to jeff@ so that he can review the VFS 
changes.

--
Suleiman Souhlal     | ssouhlal@vt.edu
The FreeBSD Project  | ssouhlal@FreeBSD.org