From owner-freebsd-questions Mon Feb 3 13:26:52 2003 Delivered-To: freebsd-questions@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 74C5F37B401; Mon, 3 Feb 2003 13:26:50 -0800 (PST) Received: from stork.mail.pas.earthlink.net (stork.mail.pas.earthlink.net [207.217.120.188]) by mx1.FreeBSD.org (Postfix) with ESMTP id EBA4043E4A; Mon, 3 Feb 2003 13:26:49 -0800 (PST) (envelope-from tlambert2@mindspring.com) Received: from pool0144.cvx21-bradley.dialup.earthlink.net ([209.179.192.144] helo=mindspring.com) by stork.mail.pas.earthlink.net with asmtp (SSLv3:RC4-MD5:128) (Exim 3.33 #1) id 18fo6x-0000l3-00; Mon, 03 Feb 2003 13:26:41 -0800 Message-ID: <3E3EDE11.192ABC3F@mindspring.com> Date: Mon, 03 Feb 2003 13:24:33 -0800 From: Terry Lambert X-Mailer: Mozilla 4.79 [en] (Win98; U) X-Accept-Language: en MIME-Version: 1.0 To: Maksim Yevmenkin Cc: hackers@FreeBSD.ORG, questions@FreeBSD.ORG, brian@freebsd.org, doconnor@gsoft.com.au, imp@bsdimp.com Subject: Re: [PATCH] PPP in -direct mode does not execute any chat scripts References: <45258A4365C6B24A9832BFE224837D552B1283@sjdcex01.int.exodus.net> <3E3ED4DF.7090904@exodus.net> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-ELNK-Trace: b1a02af9316fbb217a47c185c03b154d40683398e744b8a45ef5c479d66b3d68c482cc40c694a88d350badd9bab72f9c350badd9bab72f9c350badd9bab72f9c Sender: owner-freebsd-questions@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Maksim Yevmenkin wrote: > Please find attached patch that adds new option to the PPP. > > run-scripts-in-direct-mode > Default: Disabled. This allows to run chat scripts in > direct mode. > > did i miss anything? objections? comments? reviews? First comment: run it past Brian Somers ; it's his baby, and he's the active maintainer. Rest of comments: Actually, why doesn't "-direct" allow a chat script by default? The man page doesn't document that as a side-effect of "-direct", only of "-dedicated", but it's been there since the import. Should this really be a "negotiate" section command, rather than just a command or a "set" command? Also, there are only two other commands even have a "-" in them, and both of them only have one (just seems a little long, compared to, say, "rsid" or "direct-with-script", or even "force-script"). Personal preference: don't make it conditional on "-direct", let it also work with "-dedicated", and call it "force-script" or something, instead. The man page should be updated -- including the undocumented side-effect of "-direct" disabling scripts). -- Terry To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-questions" in the body of the message