From nobody Sat Jan 27 16:31:03 2024 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TMg6b5f04z58WDs; Sat, 27 Jan 2024 16:31:03 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TMg6b5D28z4XjN; Sat, 27 Jan 2024 16:31:03 +0000 (UTC) (envelope-from danfe@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1706373063; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Hg/VSztft1fPXkTvzYLQukQQcWOCxjZX6ZH9BnQ8weQ=; b=tezwu/Y4+AqbwOyuJjh+RdmHnuw4Tjx0it41XdHrcg2vE5YDGSPFCt38+0wdsEWpSHwd9t 3gX/DgsenextdbrXr4lbC8u7RkNtg30o3Djad+UCz3meJ6RDaiXddcgmU7z9d2Tiaq4AtZ RJ/wLuVXkPyjn45uUH/iCoj/7YtonWGZy0G7UAe8HonX4eGBCDE6JfBBuRsQDD//eJL3fR 9jANkJsl3m64HNgQ+JV7JRkY+0I70dA6l1qJ90hSiA8a2yLvJNN44064XZ81zZYP3jCY2K BVpEQZ1gM8z1HkrmyM+mOdFiGoTYVqX7QmmPi/+ypUteI4+OwoJ/joEs0hgKHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1706373063; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Hg/VSztft1fPXkTvzYLQukQQcWOCxjZX6ZH9BnQ8weQ=; b=KjEJIG9oWxdLQ6SOMIKBcDnITvanSuiuvOz+34zp+3Bpz3QTNut5RFxIuQGGzWBqXLHtO2 TBdVUTAg2AatDTgNEWvWBIBLNmHpSX9ebWHI7c3b2NnD8nxKGfnrqEMd0z30Y4AowdCVt2 u3uJdp7toxjTHJ8EBtYBuiOuPZMAqEyn7cvGACcXGQCo2VO5ESE22OfHvFmzihBurBHADc mBk+/1/QkV+M4fbk7G6vxgjbwTGimNVC8rAJ+UVmmJjUZD8EDXWWB9yvoHnCGSYMEK+BNq +yEKTZ4kvJsZ82/bESOG1RcC8Dr55qDoooUTr8NqGYIJl/j6GSq8ga56kswP1A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1706373063; a=rsa-sha256; cv=none; b=d5dyHAQp4bjHiM64k0ISGOFoevjQXfOxofEeXLY6oj6DshS3Fy3WxhZI7/VO2yDGuUXQrX 7dr7BDiN8/QL3Umhn0HvDCBgQmDEnnr2TwYJbPqQKP4Ilf++7OVZZgcBRrQW5ApNydfc1V 7aZ3aErU6h/CBqav9DIC92UGlzEXwVnOAiig/IjeCOHaHU/E5Gsfq7CaTAdAiYc0OrN1ai 2oDvNTH/3jHQ1UNG8pI97HG2w9kyGy7ztkT9wfVytZXrSzfENmlolMMTu+IKnJwq5x66Sn GJwPyQOXfuzI3blMxqOLhwGx03LqnezIsBbd3EAuFNi5iB7OvUJ02qnDNup4HA== Received: by freefall.freebsd.org (Postfix, from userid 1033) id AC64EECDB; Sat, 27 Jan 2024 16:31:03 +0000 (UTC) Date: Sat, 27 Jan 2024 16:31:03 +0000 From: Alexey Dokuchaev To: Mathieu Arnold Cc: Dirk Meyer , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: Re: git: 50c28128f2ef - main - comms/lrzsz: do not link with libbe(3) Message-ID: References: <202401271546.40RFktRR070097@gitrepo.freebsd.org> List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Sat, Jan 27, 2024 at 05:09:47PM +0100, Mathieu Arnold wrote: > On Sat, Jan 27, 2024 at 03:59:19PM +0000, Alexey Dokuchaev wrote: > > On Sat, Jan 27, 2024 at 03:46:55PM +0000, Dirk Meyer wrote: > > > commit 50c28128f2ef196caf67619027335a44b005641d > > > > > > comms/lrzsz: do not link with libbe(3) > > > > > > Submitted by: Dmitry Lukhtionov > > > PR: 276613 > > > > To make the attribution more transparent, the actual patch was > > conceived by eugen@ (Eugene Grosbein). > > If only it was actually a patch and not some sed stunt... > > We really need to stop doing this, a patch or a sed will both break if > the file gets modified, but a patch actually shows the intent of what is > being removed and makes it easier to update, wheras here, it removes 140 > lines starting at some string. While I'm a big sed(1) fan myself, recently I've been leaning more towards what you say above, however: in this case, it's an old code, looking for syslog in some obscure places like -lbe (BeOS library, not the modern one for managing ZFS boot environments). Correct patch should not be removing 140 lines at certain place, but fixing the search logic instead. Until someone(tm) could upstream it, sed(1) hack for some low-volatile code is good enough (and with git, easier to manage vs. regular patches). ./danfe