From owner-cvs-all@FreeBSD.ORG Fri Feb 12 00:22:50 2010 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BC8F6106568B for ; Fri, 12 Feb 2010 00:22:50 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx21.fluidhosting.com [204.14.89.4]) by mx1.freebsd.org (Postfix) with ESMTP id 49E578FC17 for ; Fri, 12 Feb 2010 00:22:50 +0000 (UTC) Received: (qmail 17461 invoked by uid 399); 12 Feb 2010 00:22:49 -0000 Received: from localhost (HELO foreign.dougb.net) (dougb@dougbarton.us@127.0.0.1) by localhost with ESMTPAM; 12 Feb 2010 00:22:49 -0000 X-Originating-IP: 127.0.0.1 X-Sender: dougb@dougbarton.us Message-ID: <4B749F6E.5020806@FreeBSD.org> Date: Thu, 11 Feb 2010 16:23:10 -0800 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.9.1.7) Gecko/20100123 Thunderbird/3.0.1 MIME-Version: 1.0 To: Dmitry Marakasov References: <201002092323.o19NNRvB090976@repoman.freebsd.org> <20100210092407.GA30717@FreeBSD.org> <20100210125022.GD1538@hades.panopticon> In-Reply-To: <20100210125022.GD1538@hades.panopticon> X-Enigmail-Version: 1.0 OpenPGP: id=D5B2F0FB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-ports@FreeBSD.org, Alexey Dokuchaev , cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/audio Makefile ports/audio/deadbeef Makefile distinfo pkg-descr pkg-plist ports/audio/deadbeef/files patch-Makefile.am patch-Makefile.in patch-configure patch-configure.ac X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Feb 2010 00:22:50 -0000 On 02/10/10 04:50, Dmitry Marakasov wrote: >>> 1.1 +13 -0 ports/audio/deadbeef/files/patch-Makefile.am (new) >>> 1.1 +21 -0 ports/audio/deadbeef/files/patch-Makefile.in (new) >> >> Weird. Can you explain why both of these patches are required, since .in >> is normally generated from .am (that is, patching .in is enough unless >> the port needs more of autotools magic than simple "./configure")? > > Configure tends to rerun autotools when available sometimes, thus files > gets regenerated, so to be on a safe side, sources are patched as well. > Anyway, these patches will go away with the next update. Yes, TMK it has always been common practice to patch both files "just in case." One never knows what may happen with future versions of auto*, for example. Doug -- ... and that's just a little bit of history repeating. -- Propellerheads Improve the effectiveness of your Internet presence with a domain name makeover! http://SupersetSolutions.com/