From owner-svn-src-head@freebsd.org Wed Jul 4 02:14:59 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9F08210166E1; Wed, 4 Jul 2018 02:14:59 +0000 (UTC) (envelope-from mmacy@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4D2417E2EE; Wed, 4 Jul 2018 02:14:59 +0000 (UTC) (envelope-from mmacy@freebsd.org) Received: from mail-it0-f51.google.com (mail-it0-f51.google.com [209.85.214.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) (Authenticated sender: mmacy) by smtp.freebsd.org (Postfix) with ESMTPSA id 10AE31925E; Wed, 4 Jul 2018 02:14:59 +0000 (UTC) (envelope-from mmacy@freebsd.org) Received: by mail-it0-f51.google.com with SMTP id o5-v6so5806530itc.1; Tue, 03 Jul 2018 19:14:59 -0700 (PDT) X-Gm-Message-State: APt69E07KyFbaoGAWz9dYqb4SUsmEbzyWyoEMIa07za6Z4UDLPwgz8/7 kt98K1zmM8HZppvFB1XsH7zNUquDA/BYnIqKOeA= X-Google-Smtp-Source: AAOMgpdT/gW7QnjN9sjQ4gwRqtnMf6ciYqs/pkndYQPL5zT+Pwtu93SARF91Q/NZ2W+vO1/8oYGUCC+MYkZy8B+34Gw= X-Received: by 2002:a24:8ac1:: with SMTP id v184-v6mr382033itd.7.1530670498550; Tue, 03 Jul 2018 19:14:58 -0700 (PDT) MIME-Version: 1.0 References: <201807032305.w63N5guY063293@repo.freebsd.org> In-Reply-To: From: Matthew Macy Date: Tue, 3 Jul 2018 19:14:47 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r335916 - head/sys/conf To: Warner Losh Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.27 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Jul 2018 02:14:59 -0000 I didn't want it to be global. Note that I did _exactly_ what John told me to. I don't believe the tone or word choice is justified. -M On Tue, Jul 3, 2018 at 17:32 Warner Losh wrote: > And this is why I wanted it to conform to the current build paradigm in my > review... I'll mop it up once Bryan is done... > > Warner > > On Tue, Jul 3, 2018, 6:05 PM Matt Macy wrote: > >> Author: mmacy >> Date: Tue Jul 3 23:05:42 2018 >> New Revision: 335916 >> URL: https://svnweb.freebsd.org/changeset/base/335916 >> >> Log: >> Enable MODULE_TIED by default for modules compiled with the kernel >> >> Requested by: jhb >> >> Modified: >> head/sys/conf/kern.post.mk >> >> Modified: head/sys/conf/kern.post.mk >> >> ============================================================================== >> --- head/sys/conf/kern.post.mk Tue Jul 3 22:54:46 2018 (r335915) >> +++ head/sys/conf/kern.post.mk Tue Jul 3 23:05:42 2018 (r335916) >> @@ -14,6 +14,7 @@ MKMODULESENV+= DESTDIR="${DESTDIR}" >> .endif >> SYSDIR?= ${S:C;^[^/];${.CURDIR}/&;:tA} >> MKMODULESENV+= KERNBUILDDIR="${.CURDIR}" SYSDIR="${SYSDIR}" >> +MKMODULESENV+= MODULE_TIED=yes >> >> .if defined(CONF_CFLAGS) >> MKMODULESENV+= CONF_CFLAGS="${CONF_CFLAGS}" >> >>