From owner-freebsd-current@FreeBSD.ORG Sat Nov 6 10:31:22 2010 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8FCC01065670 for ; Sat, 6 Nov 2010 10:31:22 +0000 (UTC) (envelope-from barbara.xxx1975@libero.it) Received: from cp-out2.libero.it (cp-out2.libero.it [212.52.84.102]) by mx1.freebsd.org (Postfix) with ESMTP id 2A3C48FC17 for ; Sat, 6 Nov 2010 10:31:22 +0000 (UTC) Received: from wmail46 (172.31.0.236) by cp-out2.libero.it (8.5.107) (authenticated as barbara.xxx1975@libero.it) id 4CCEC8E5006586B1; Sat, 6 Nov 2010 11:31:20 +0100 Message-ID: <13873405.926621289039480757.JavaMail.defaultUser@defaultHost> Date: Sat, 6 Nov 2010 11:31:20 +0100 (CET) From: Barbara To: MIME-Version: 1.0 Content-Type: text/plain;charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-SenderIP: 79.3.210.9 Cc: dudu@dudu.ro Subject: libstc++ (?) problem on CURRENT? X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Barbara List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Nov 2010 10:31:22 -0000 >On Sat, Nov 6, 2010 at 10:57 AM, Barbara wrote= : >> >> I had a problem running the IcedTea java plugin on CURRENT i386, while i= t >> works on 8_STABLE. >> But maybe it's not a problem related to the port. >> Just to be clear, I'm not looking for a solution about the port here, I'= m=20 just >> wondering why the same c++ code is working on 8_STABLE and it's segfault= ing=20 on >> CURRENT, considering also that AFAIK the gcc version in both the base=20 systems >> is the same. >> >> In the part of the code causing the crash, a std::map is read with an=20 iterator >> in a for loop, and if a condition is met, an entry is erased. >> The following is the bt I'm getting: >> #0 =C2=A00x29e36247 in kill () from /lib/libc.so.7 >> #1 =C2=A00x29e361a6 in raise () from /lib/libc.so.7 >> #2 =C2=A00x282424f6 in XRE_LockProfileDirectory () from >> =C2=A0 =C2=A0 =C2=A0 =C2=A0/usr/local/lib/firefox3/libxul.so >> #3 =C2=A0 >> #4 =C2=A00x29c8f1b2 in std::_Rb_tree_increment () from >> =C2=A0 =C2=A0 =C2=A0 =C2=A0/usr/lib/libstdc++.so.6 #5 =C2=A00x2ef92402 i= n >> =C2=A0 =C2=A0 =C2=A0 =C2=A0IcedTeaPluginUtilities::invalidateInstance ()= from >> =C2=A0 =C2=A0 =C2=A0 =C2=A0/usr/local/openjdk6/jre/lib/IcedTeaPlugin.so >> ... >> >> I wrote a "patch" for the IcedTea plugin, replacing the for loop with a= =20 while >> and increasing the iterator before erasing from the map, and it seems=20 working. >> Then I wrote a simple program that do something similar to IcedTea, so= =20 there >> is no need to build the whole java/openjdk6 port to do some testing. >> Running it on 8_STABLE it works, on CURRENT it crashes. >> You can find more details in this discussion on the freebsd-java ml: >> http://lists.freebsd.org/pipermail/freebsd-java/2010-November/008978.htm= l >> >> You can find the patch and the sample code in the discussion above, anyw= ay=20 I'm >> reporting them here too: >> icedtea patch: >> http://pastebin.com/b2KKFNSG >> test case: >> http://pastebin.com/Amk4UJ0g > >You appear to invalidate the iterator inside the loop and then >increment it. Do the following: > >-- cut here -- >for (iter =3D cars.begin(); iter !=3D cars.end(); ) { > if ((*iter).second =3D=3D modelName) > cars.erase(iter++); > else > ++iter; >} >-- and here -- > >In this example, you first increment the iterator and then erase its >previous value. > So there is a bug in my source code! Well, I'm not surprised. I'm trying to report the code in icedtea here, extracting it from the patch= so=20 I hope it's accurate enough: std::map::iterator iterator;=20 for (iterator =3D instance_map->begin(); iterator !=3D instance_map->en= d();=20 iterator++) { if ((*iterator).second =3D=3D instance) { instance_map->erase((*iterator).first); } } So, do you think, like Ed Schouten said, that there is a bug in the source= =20 code but it's just exposed on CURRENT? Is that code bad too? Thanks Barbara