Date: Sun, 23 Jul 2023 18:18:37 GMT From: Xin LI <delphij@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: git: 9df529b8a106 - main - login_getclassbyname(3): use calloc. Message-ID: <202307231818.36NIIboM042235@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch main has been updated by delphij: URL: https://cgit.FreeBSD.org/src/commit/?id=9df529b8a106b18b15d561f7ae94f474c3fb4a7d commit 9df529b8a106b18b15d561f7ae94f474c3fb4a7d Author: Xin LI <delphij@FreeBSD.org> AuthorDate: 2023-07-23 18:18:24 +0000 Commit: Xin LI <delphij@FreeBSD.org> CommitDate: 2023-07-23 18:18:24 +0000 login_getclassbyname(3): use calloc. --- lib/libutil/login_cap.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/lib/libutil/login_cap.c b/lib/libutil/login_cap.c index ffefb865ed5e..6b3bf663bb2b 100644 --- a/lib/libutil/login_cap.c +++ b/lib/libutil/login_cap.c @@ -295,7 +295,7 @@ login_getclassbyname(char const *name, const struct passwd *pwd) { login_cap_t *lc; - if ((lc = malloc(sizeof(login_cap_t))) != NULL) { + if ((lc = calloc(1, sizeof(login_cap_t))) != NULL) { int r, me, i = 0; uid_t euid = 0; gid_t egid = 0; @@ -332,9 +332,6 @@ login_getclassbyname(char const *name, const struct passwd *pwd) login_dbarray[i++] = path_login_conf; login_dbarray[i] = NULL; - memset(lc, 0, sizeof(login_cap_t)); - lc->lc_cap = lc->lc_class = lc->lc_style = NULL; - if (name == NULL || *name == '\0') name = LOGIN_DEFCLASS;
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202307231818.36NIIboM042235>