From owner-svn-src-all@freebsd.org Wed Nov 30 05:39:58 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 92432C5CB42; Wed, 30 Nov 2016 05:39:58 +0000 (UTC) (envelope-from jakub@ixsystems.com) Received: from mx.ixsystems.com (mail.ixsystems.com [12.229.62.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN ".", Issuer "." (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 244241EDA; Wed, 30 Nov 2016 05:39:58 +0000 (UTC) (envelope-from jakub@ixsystems.com) Received: from localhost (localhost.localdomain [127.0.0.1]) by mx.ixsystems.com (Postfix) with ESMTP id 3tSSmg6bK1zCs4F; Mon, 28 Nov 2016 18:53:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ixsystems.com; h= x-mailer:references:message-id:content-transfer-encoding:date :date:in-reply-to:from:from:subject:subject:mime-version :content-type:content-type:received:received:received:received :received:received:received; s=dkim; t=1480388030; x=1482202431; bh=hCXKvsRvN+beCkw8PVA/gnARr52oB92qL/OIapyuFaE=; b=eeoSFg74r9PE 81Xy03vvTyA50R9XDkAKz2gzEbBIQQG6OSgPLJqUL9oZxSBN0zAkr/wKoKZu8StL 6U/vmO0FRRrZBuimr05dRSdbcTVEl6nj6C3ojvbX4nMt7gf6/8lJky08gZrSJUiT FgYq5UL/k9SgcdgyzZ1y81XcZeKikhdW+8uQaPme2X299KvgD5ZlRnSBRRZhK2pO SfNAbl9StHCRvCcA/eQwWqwKy9FP6XGD+e+XPzadEnaRsYGjf+zR+C+CqazDduxE p9vSZJK7mTVz4Gi2H8GmVr/wKOPK/aCeG74t6NVQ9kJ+asNodY1El2nGY7FOGIEN nMYn108QUg== X-Amavis-Modified: Mail body modified (using disclaimer) - mx.ixsystems.com X-Virus-Scanned: Scrollout F1 at ixsystems.com Received: from mx.ixsystems.com ([127.0.0.1]) by localhost (mx.ixsystems.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id X0VAuMUryfQI; Mon, 28 Nov 2016 18:53:50 -0800 (PST) Received: from zimbra.ixsystems.com (unknown [10.246.0.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx.ixsystems.com (Postfix) with ESMTPS id 3tSSm733FHzCs7r; Mon, 28 Nov 2016 18:53:27 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by zimbra.ixsystems.com (Postfix) with ESMTP id 203B1C4E0DD; Thu, 24 Nov 2016 14:27:10 -0800 (PST) Received: from zimbra.ixsystems.com ([127.0.0.1]) by localhost (zimbra.ixsystems.com [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 7mmTssxD37CL; Thu, 24 Nov 2016 14:27:09 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by zimbra.ixsystems.com (Postfix) with ESMTP id 3E642C4E130; Thu, 24 Nov 2016 14:27:09 -0800 (PST) X-Virus-Scanned: amavisd-new at ixsystems.com Received: from zimbra.ixsystems.com ([127.0.0.1]) by localhost (zimbra.ixsystems.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id kcxlAuZqb47J; Thu, 24 Nov 2016 14:27:09 -0800 (PST) Received: from [172.20.0.30] (vpn.ixsystems.com [10.249.0.2]) by zimbra.ixsystems.com (Postfix) with ESMTPSA id EB664C4E0DD; Thu, 24 Nov 2016 14:27:07 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 10.0 \(3226\)) Subject: Re: svn commit: r309121 - head/usr.sbin/bhyve From: Jakub Klama In-Reply-To: <1480026232.1889.63.camel@freebsd.org> Date: Thu, 24 Nov 2016 23:27:04 +0100 Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <7F692FF4-4F36-4ED8-AF26-4684D41CB3AE@ixsystems.com> References: <201611242216.uAOMGIi0065703@repo.freebsd.org> <1480026232.1889.63.camel@freebsd.org> To: Ian Lepore X-Mailer: Apple Mail (2.3226) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Nov 2016 05:39:58 -0000 > Wiadomo=C5=9B=C4=87 napisana przez Ian Lepore w dniu = 24.11.2016, o godz. 23:23: >=20 > On Thu, 2016-11-24 at 22:16 +0000, Jakub Wojciech Klama wrote: >> Author: jceel >> Date: Thu Nov 24 22:16:18 2016 >> New Revision: 309121 >> URL: https://svnweb.freebsd.org/changeset/base/309121 >>=20 >> Log: >> virtio_console: handle short writes to an Unix domain socket >> gracefully. >>=20 >> writev() can do a short write. Retrying it results in a very >> convoluted >> and complex code, so we iterate over iovec and do regular >> stream_write() >> instead. >>=20 >=20 > Doesn't pwritev(2) simplify iterating to handle short writes? >=20 Correct me if I'm wrong, but pwritev(2) is a writev(2) with offset. = We're writing to an Unix domain socket here, which is not seekable. Thanks, Jakub