From owner-freebsd-bugs@FreeBSD.ORG Fri Apr 8 17:30:09 2005 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8272916A4CE for ; Fri, 8 Apr 2005 17:30:09 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 20AA743D53 for ; Fri, 8 Apr 2005 17:30:09 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j38HU80l043995 for ; Fri, 8 Apr 2005 17:30:08 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j38HU8va043994; Fri, 8 Apr 2005 17:30:08 GMT (envelope-from gnats) Resent-Date: Fri, 8 Apr 2005 17:30:08 GMT Resent-Message-Id: <200504081730.j38HU8va043994@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Jim Kuhn Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B3CFA16A4D0 for ; Fri, 8 Apr 2005 17:26:37 +0000 (GMT) Received: from www.freebsd.org (www.freebsd.org [216.136.204.117]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9657B43D1D for ; Fri, 8 Apr 2005 17:26:37 +0000 (GMT) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.13.1/8.13.1) with ESMTP id j38HQbls058620 for ; Fri, 8 Apr 2005 17:26:37 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.13.1/8.13.1/Submit) id j38HQbnU058586; Fri, 8 Apr 2005 17:26:37 GMT (envelope-from nobody) Message-Id: <200504081726.j38HQbnU058586@www.freebsd.org> Date: Fri, 8 Apr 2005 17:26:37 GMT From: Jim Kuhn To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-2.3 Subject: bin/79690: [patch] mdmfs does not accept numeric uid/gid with -w X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Apr 2005 17:30:09 -0000 >Number: 79690 >Category: bin >Synopsis: [patch] mdmfs does not accept numeric uid/gid with -w >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Fri Apr 08 17:30:08 GMT 2005 >Closed-Date: >Last-Modified: >Originator: Jim Kuhn >Release: 5.3.0 >Organization: Sandvine Incorporated >Environment: FreeBSD TPC-D4-39.sandvine.com 5.31.0003 FreeBSD 5.31.0003 #0: Tue Mar 1 18:12:17 UTC 2005 i386 7.20.0003 >Description: While mdfs correctly processes a numeric uid:gid combination, it fails to set the appropriate mi_have_* flags, which causes an assertion that both uid and gid to fail. >How-To-Repeat: >Fix: --- mdmfs.c@@/main/sandvine_gluon/0 2005-04-08 11:18:47.000000000 -0400 +++ mdmfs.c 2005-04-08 13:23:43.000000000 -0400 @@ -518,27 +518,27 @@ /* Derive uid. */ *uid = strtoul(user, &p, 10); - if (*uid == (uid_t)ULONG_MAX) + if (*user == '\0' || *uid == (uid_t)ULONG_MAX) usage(); if (*p != '\0') { pw = getpwnam(user); if (pw == NULL) errx(1, "invalid user: %s", user); *uid = pw->pw_uid; - mip->mi_have_uid = true; } + mip->mi_have_uid = true; /* Derive gid. */ *gid = strtoul(group, &p, 10); - if (*gid == (gid_t)ULONG_MAX) + if (*group == '\0' || *gid == (gid_t)ULONG_MAX) usage(); if (*p != '\0') { gr = getgrnam(group); if (gr == NULL) errx(1, "invalid group: %s", group); *gid = gr->gr_gid; - mip->mi_have_gid = true; } + mip->mi_have_gid = true; free(ug); /* >Release-Note: >Audit-Trail: >Unformatted: