From owner-svn-src-head@FreeBSD.ORG Fri Oct 1 14:03:37 2010 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CECA010656A8; Fri, 1 Oct 2010 14:03:37 +0000 (UTC) (envelope-from mdf356@gmail.com) Received: from mail-iw0-f182.google.com (mail-iw0-f182.google.com [209.85.214.182]) by mx1.freebsd.org (Postfix) with ESMTP id 6BB908FC14; Fri, 1 Oct 2010 14:03:37 +0000 (UTC) Received: by iwn34 with SMTP id 34so4741133iwn.13 for ; Fri, 01 Oct 2010 07:03:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:sender:received :in-reply-to:references:date:x-google-sender-auth:message-id:subject :from:to:cc:content-type:content-transfer-encoding; bh=8qXsz9QwRX9PikCaJeopYP42HX28zlj3+9NMnvzozWI=; b=cRBZ/cdesY18lZWcj0ZysLSKkdU7PYmNwk0wcU2yo6DpS8RALFv/ECXDEyH1QF8rZ2 7NufjmffC25fjLbVQbhYiur/XnQJSW+FKxmlsORLFu6z8Uhl5MQtEVRukHyWpR1yuOYR 1VnmpVHu6ucTjcdS+3KznwakSpYN/HtonNePw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=RzydgohaIjYy9223Xjj+ZRNmEzMACWNw62Zxw5V4yNdeA/OHCxuxvZikqBFwTspj1i 7rMcaHyohredTx50QOthq6VFkiyR5FVPhagUCG/K5gvhn0Koi5s3KpFQp4/rLC/tyJNn bo4xuDnfZbvzpsQQYRzRDFN95JIEjAkE1/AGY= MIME-Version: 1.0 Received: by 10.231.148.83 with SMTP id o19mr5704330ibv.112.1285941816769; Fri, 01 Oct 2010 07:03:36 -0700 (PDT) Sender: mdf356@gmail.com Received: by 10.231.167.140 with HTTP; Fri, 1 Oct 2010 07:03:36 -0700 (PDT) In-Reply-To: <201010010934.o919YfCB097349@svn.freebsd.org> References: <201010010934.o919YfCB097349@svn.freebsd.org> Date: Fri, 1 Oct 2010 14:03:36 +0000 X-Google-Sender-Auth: 2_gWfo8_WZcaxVK9p4sUQCqruhM Message-ID: From: mdf@FreeBSD.org To: Andriy Gapon Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r213322 - head/sys/kern X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Oct 2010 14:03:38 -0000 On Fri, Oct 1, 2010 at 9:34 AM, Andriy Gapon wrote: > Author: avg > Date: Fri Oct =A01 09:34:41 2010 > New Revision: 213322 > URL: http://svn.freebsd.org/changeset/base/213322 > > Log: > =A0sysctls in kern_shutdown: add twin tunables > > =A0also make couple of sysctl-controlled variables static > > =A0Reviewed by: =A0rwatson > =A0MFC after: =A0 =A01 week > > Modified: > =A0head/sys/kern/kern_shutdown.c > > Modified: head/sys/kern/kern_shutdown.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/kern/kern_shutdown.c =A0 =A0 =A0 Fri Oct =A01 09:18:30 2010 = =A0 =A0 =A0 =A0(r213321) > +++ head/sys/kern/kern_shutdown.c =A0 =A0 =A0 Fri Oct =A01 09:34:41 2010 = =A0 =A0 =A0 =A0(r213322) > @@ -98,21 +98,24 @@ int debugger_on_panic =3D 0; > =A0#else > =A0int debugger_on_panic =3D 1; > =A0#endif > -SYSCTL_INT(_debug, OID_AUTO, debugger_on_panic, CTLFLAG_RW, > +SYSCTL_INT(_debug, OID_AUTO, debugger_on_panic, CTLFLAG_RW | CTLFLAG_TUN= , > =A0 =A0 =A0 =A0&debugger_on_panic, 0, "Run debugger on kernel panic"); I thought CTLFLAG_TUN was only used to provide a more useful error message when writing to a read-only sysctl? I think the CTLFLAG_TUN should not be here for a RW sysctl. Thanks, matthew > +TUNABLE_INT("debug.debugger_on_panic", &debugger_on_panic); > > =A0#ifdef KDB_TRACE > -int trace_on_panic =3D 1; > +static int trace_on_panic =3D 1; > =A0#else > -int trace_on_panic =3D 0; > +static int trace_on_panic =3D 0; > =A0#endif > -SYSCTL_INT(_debug, OID_AUTO, trace_on_panic, CTLFLAG_RW, > +SYSCTL_INT(_debug, OID_AUTO, trace_on_panic, CTLFLAG_RW | CTLFLAG_TUN, > =A0 =A0 =A0 =A0&trace_on_panic, 0, "Print stack trace on kernel panic"); > +TUNABLE_INT("debug.trace_on_panic", &trace_on_panic); > =A0#endif /* KDB */ > > -int sync_on_panic =3D 0; > -SYSCTL_INT(_kern, OID_AUTO, sync_on_panic, CTLFLAG_RW, > +static int sync_on_panic =3D 0; > +SYSCTL_INT(_kern, OID_AUTO, sync_on_panic, CTLFLAG_RW | CTLFLAG_TUN, > =A0 =A0 =A0 =A0&sync_on_panic, 0, "Do a sync before rebooting from a pani= c"); > +TUNABLE_INT("kern.sync_on_panic", &sync_on_panic); > > =A0SYSCTL_NODE(_kern, OID_AUTO, shutdown, CTLFLAG_RW, 0, "Shutdown enviro= nment"); > >